From 45d95c2619d09b891256562688ed4330de466cfd Mon Sep 17 00:00:00 2001
From: adrienperonnet <adrien@vendhq.com>
Date: Fri, 26 Apr 2019 22:31:50 +1200
Subject: [PATCH] Pass by value when possible & refresh can be private

ProviderConfig not modified and not large so can be on stack
---
 provider/provider.go | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/provider/provider.go b/provider/provider.go
index a7d6017..56d87e7 100644
--- a/provider/provider.go
+++ b/provider/provider.go
@@ -51,7 +51,7 @@ type OAuth2Token struct {
 	IDToken      string    `json:"id_token,omitempty"`
 }
 
-func (t *OAuth2Token) Refresh(config *oauth2.Config) error {
+func refresh(config oauth2.Config, t *OAuth2Token) error {
 	ctx := context.Background()
 
 	tokenSourceToken := oauth2.Token{
@@ -81,7 +81,7 @@ func (t *OAuth2Token) Refresh(config *oauth2.Config) error {
 	return nil
 }
 
-func (p *ProviderConfig) Authenticate(t *OAuth2Token) error {
+func (p ProviderConfig) Authenticate(t *OAuth2Token) error {
 	ctx := context.Background()
 	resultChannel := make(chan *oauth2.Token, 0)
 	errorChannel := make(chan error, 0)
@@ -114,7 +114,7 @@ func (p *ProviderConfig) Authenticate(t *OAuth2Token) error {
 	}
 
 	if t != nil {
-		if err := t.Refresh(&config); err != nil {
+		if err := refresh(config, t); err != nil {
 			return nil
 		}
 		log.Println(err)