lordwelch/aws-oidc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Pass by value when possible & refresh can be private

Browse Source 
ProviderConfig not modified and not large so can be on stack
This commit is contained in:
adrienperonnet 2019-04-26 22:31:50 +12:00
parent 143f5deb99
commit 45d95c2619
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
provider/provider.go
View File

@ -51,7 +51,7 @@ type OAuth2Token struct {
IDToken string `json:"id_token,omitempty"` IDToken string `json:"id_token,omitempty"`
} }
func (t *OAuth2Token) Refresh(config *oauth2.Config) error { func refresh(config oauth2.Config, t *OAuth2Token) error {
ctx := context.Background() ctx := context.Background()
tokenSourceToken := oauth2.Token{ tokenSourceToken := oauth2.Token{
@ -81,7 +81,7 @@ func (t *OAuth2Token) Refresh(config *oauth2.Config) error {
return nil return nil
} }
func (p *ProviderConfig) Authenticate(t *OAuth2Token) error { func (p ProviderConfig) Authenticate(t *OAuth2Token) error {
ctx := context.Background() ctx := context.Background()
resultChannel := make(chan *oauth2.Token, 0) resultChannel := make(chan *oauth2.Token, 0)
errorChannel := make(chan error, 0) errorChannel := make(chan error, 0)
@ -114,7 +114,7 @@ func (p *ProviderConfig) Authenticate(t *OAuth2Token) error {
} }
if t != nil { if t != nil {
if err := t.Refresh(&config); err != nil { if err := refresh(config, t); err != nil {
return nil return nil
} }
log.Println(err) log.Println(err)