lordwelch/breakglass
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ssh: fix shell payload string length (#2)

Browse Source 
Using ssh.Unmarshal since commit c11ed6a015a8da means the "shell" payload should be propely formatted, with a specified string length. Otherwise, when attempting to connect, you'll see this message in the gokrazy stderr:
ssh: parse error in message type 0

that's because in x/crypto/ssh, the parseString() method expects a length before the string. If length is 0, there will be remaining unparsed data, and an error.
This commit is contained in:
Anisse Astier 2018-12-28 16:20:43 +01:00 committed by Michael Stapelberg
parent 05fda29dea
commit 9d10c020d8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ssh.go
View File

@ -151,7 +151,7 @@ func (s *session) request(ctx context.Context, req *ssh.Request) error {
s.env = append(s.env, fmt.Sprintf("%s=%s", r.VariableName, r.VariableValue)) s.env = append(s.env, fmt.Sprintf("%s=%s", r.VariableName, r.VariableValue))
case "shell": case "shell":
req.Payload = []byte("\x00\x00\x00\x00sh") req.Payload = []byte("\x00\x00\x00\x02sh")
fallthrough fallthrough
case "exec": case "exec":