a996106eee
The RFCs are very clear that in DATA contents: > CR and LF MUST only occur together as CRLF; they MUST NOT appear > independently in the body. https://www.rfc-editor.org/rfc/rfc5322#section-2.3 https://www.rfc-editor.org/rfc/rfc5321#section-2.3.8 Allowing "independent" CR and LF can cause a number of problems. In particular, there is a new "SMTP smuggling attack" published recently that involves the server incorrectly parsing the end of DATA marker `\r\n.\r\n`, which an attacker can exploit to impersonate a server when email is transmitted server-to-server. https://www.postfix.org/smtp-smuggling.html https://sec-consult.com/blog/detail/smtp-smuggling-spoofing-e-mails-worldwide/ Currently, chasquid is vulnerable to this attack, because Go's standard libraries net/textproto and net/mail do not enforce CRLF strictly. This patch fixes the problem by introducing a new "dot reader" function that strictly enforces CRLF when reading dot-terminated data, used in the DATA input processing. When an invalid newline terminator is found, the connection is aborted immediately because we cannot safely recover from that state. We still keep the internal representation as LF-terminated for convenience and simplicity. However, the MDA courier is changed to pass CRLF-terminated lines, since that is an external program which could be strict when receiving email messages. See https://github.com/albertito/chasquid/issues/47 for more details and discussion.
30 lines
681 B
Plaintext
30 lines
681 B
Plaintext
|
|
c tcp_connect localhost:1025
|
|
|
|
c <~ 220
|
|
c -> EHLO localhost
|
|
c <... 250 HELP
|
|
c -> MAIL FROM: <>
|
|
c <~ 250
|
|
c -> RCPT TO: user@testserver
|
|
c <~ 250
|
|
c -> DATA
|
|
c <~ 354
|
|
c -> From: Mailer daemon <somewhere@horns.com>
|
|
c -> Subject: I've come to haunt you
|
|
c ->
|
|
c -> Muahahahaha
|
|
c ->
|
|
|
|
# An MTA must not accept isolated line breaks, otherwise it may fall victim to
|
|
# an SMTP smuggling attack. See readUntilDot for more details.
|
|
# This test triggers that condition with an invalid dot-ending, so we verify
|
|
# the server returns an error in this case.
|
|
c ~> '.\n'
|
|
|
|
c -> That was a bad line ending, this is a good one.
|
|
c ~> 'xxx\r\n.\r\n'
|
|
|
|
c <- 521 5.5.2 Error reading DATA: invalid line ending
|
|
|