Code cleanup
Remove no longer used google scripts
Remove convenience files from comicataggerlib and import comicapi directly
Add type-hints to facilitate auto-complete tools
Make PyQt5 code more compatible with PyQt6
Implement automatic tooling
isort and black for code formatting
Line length has been set to 120
flake8 for code standards with exceptions:
E203 - Whitespace before ':' - format compatiblity with black
E501 - Line too long - flake8 line limit cannot be set
E722 - Do not use bare except - fixing bare except statements is a
lot of overhead and there are already
many in the codebase
These changes, along with some manual fixes creates much more readable code.
See examples below:
diff --git a/comicapi/comet.py b/comicapi/comet.py
index d1741c5..52dc195 100644
--- a/comicapi/comet.py
+++ b/comicapi/comet.py
@@ -166,7 +166,2 @@ class CoMet:
- if credit['role'].lower() in set(self.editor_synonyms):
- ET.SubElement(
- root,
- 'editor').text = "{0}".format(
- credit['person'])
@@ -174,2 +169,4 @@ class CoMet:
self.indent(root)
+ if credit["role"].lower() in set(self.editor_synonyms):
+ ET.SubElement(root, "editor").text = str(credit["person"])
diff --git a/comictaggerlib/autotagmatchwindow.py b/comictaggerlib/autotagmatchwindow.py
index 4338176..9219f01 100644
--- a/comictaggerlib/autotagmatchwindow.py
+++ b/comictaggerlib/autotagmatchwindow.py
@@ -63,4 +63,3 @@ class AutoTagMatchWindow(QtWidgets.QDialog):
self.skipButton, QtWidgets.QDialogButtonBox.ActionRole)
- self.buttonBox.button(QtWidgets.QDialogButtonBox.Ok).setText(
- "Accept and Write Tags")
+ self.buttonBox.button(QtWidgets.QDialogButtonBox.StandardButton.Ok).setText("Accept and Write Tags")
diff --git a/comictaggerlib/cli.py b/comictaggerlib/cli.py
index 688907d..dbd0c2e 100644
--- a/comictaggerlib/cli.py
+++ b/comictaggerlib/cli.py
@@ -293,7 +293,3 @@ def process_file_cli(filename, opts, settings, match_results):
if opts.raw:
- print((
- "{0}".format(
- str(
- ca.readRawCIX(),
- errors='ignore'))))
+ print(ca.read_raw_cix())
else:
2022-04-01 16:50:46 -07:00
|
|
|
This folder contains a set of example scripts that be used to extend the
|
|
|
|
|
capabilities of the ComicTagger app. They can be run either directly through
|
|
|
|
|
the python interpreter, or via the ComicTagger app.
|
|
|
|
|
|
|
|
|
|
To run via python directly, install ComicTagger source on your system using
|
|
|
|
|
the setup.py file.
|
|
|
|
|
|
|
|
|
|
To run via the ComicTagger app, invoke:
|
|
|
|
|
|
|
|
|
|
$ comictagger.py -S script.py [script args]
|
|
|
|
|
|
|
|
|
|
(This will work also for binary distributions on Mac and Windows. No need for
|
|
|
|
|
an extra python install.)
|
|
|
|
|
|
|
|
|
|
The script must have an entry point function called "main()" to be invoked
|
|
|
|
|
via the app.
|
|
|
|
|
|
|
|
|
|
-----------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
This feature is UNSUPPORTED, and is for the convenience of development-minded
|
|
|
|
|
users of ComicTagger. The comictaggerlib module will remain largely
|
|
|
|
|
undocumented, and it will be up to the crafty script developer to look through
|
|
|
|
|
the code to discern APIs and such.
|
|
|
|
|
|
|
|
|
|
That said, if there are questions, please post in the forums, and hopefully we
|
|
|
|
|
can get your add-on scripts working!
|
|
|
|
|
|
|
|
|
|
http://comictagger.forumotion.com/
|