From 085b599bc43bf02101b562887fcc75e5088bd758 Mon Sep 17 00:00:00 2001
From: Mizaki <jinxybob@hotmail.com>
Date: Fri, 14 Feb 2025 00:59:10 +0000
Subject: [PATCH] Parametrise cover match test and add ImageHash data

---
 testing/comicdata.py          | 73 +++++++++++++++++++++++++++++++++++
 tests/issueidentifier_test.py | 24 ++++++------
 2 files changed, 86 insertions(+), 11 deletions(-)

diff --git a/testing/comicdata.py b/testing/comicdata.py
index cafbe16..3832b11 100644
--- a/testing/comicdata.py
+++ b/testing/comicdata.py
@@ -288,3 +288,76 @@ metadata_prepared = (
         ),
     ),
 )
+
+issueidentifier_score = (
+    (
+        (
+            comicapi.genericmetadata.ImageHash(
+                Hash=0,  # Force using the alternate, since the alternate is a url it will be ignored
+                Kind="ahash",
+            ),
+            ["https://comicvine.gamespot.com/cory-doctorows-futuristic-tales-of-the-here-and-no/4000-140529/"],
+            True,
+        ),
+        {
+            "remote_hash": 0,
+            "score": 31,
+            "url": "",
+            "local_hash": 212201432349720,
+            "local_hash_name": "Cover 1",
+        },
+    ),
+    (
+        (
+            comicapi.genericmetadata.ImageHash(
+                Hash=0,
+                Kind="ahash",
+            ),
+            [
+                comicapi.genericmetadata.ImageHash(
+                    Hash=212201432349720,
+                    Kind="ahash",
+                ),
+            ],
+            True,
+        ),
+        {
+            "remote_hash": 212201432349720,
+            "score": 0,
+            "url": "",
+            "local_hash": 212201432349720,
+            "local_hash_name": "Cover 1",
+        },
+    ),
+    (
+        (
+            comicapi.genericmetadata.ImageHash(
+                Hash=212201432349720,
+                Kind="ahash",
+            ),
+            ["https://comicvine.gamespot.com/cory-doctorows-futuristic-tales-of-the-here-and-no/4000-140529/"],
+            False,
+        ),
+        {
+            "remote_hash": 212201432349720,
+            "score": 0,
+            "url": "",
+            "local_hash": 212201432349720,
+            "local_hash_name": "Cover 1",
+        },
+    ),
+    (
+        (
+            "https://comicvine.gamespot.com/a/uploads/scale_large/0/574/585444-109004_20080707014047_large.jpg",
+            ["https://comicvine.gamespot.com/cory-doctorows-futuristic-tales-of-the-here-and-no/4000-140529/"],
+            False,
+        ),
+        {
+            "remote_hash": 212201432349720,
+            "score": 0,
+            "url": "https://comicvine.gamespot.com/a/uploads/scale_large/0/574/585444-109004_20080707014047_large.jpg",
+            "local_hash": 212201432349720,
+            "local_hash_name": "Cover 1",
+        },
+    ),
+)
diff --git a/tests/issueidentifier_test.py b/tests/issueidentifier_test.py
index bec1f80..9e96a3a 100644
--- a/tests/issueidentifier_test.py
+++ b/tests/issueidentifier_test.py
@@ -9,6 +9,7 @@ import comictaggerlib.imagehasher
 import comictaggerlib.issueidentifier
 import testing.comicdata
 import testing.comicvine
+from comicapi.genericmetadata import ImageHash
 from comictaggerlib.resulttypes import IssueResult
 
 
@@ -36,21 +37,22 @@ def test_get_search_keys(cbz, config, additional_md, expected, comicvine_api):
     assert expected == ii._get_search_keys(additional_md)
 
 
-def test_get_issue_cover_match_score(cbz, config, comicvine_api):
+@pytest.mark.parametrize("data, expected", testing.comicdata.issueidentifier_score)
+def test_get_issue_cover_match_score(
+    cbz,
+    config,
+    comicvine_api,
+    data: tuple[str | ImageHash, list[str | ImageHash], bool],
+    expected: comictaggerlib.issueidentifier.Score,
+):
     config, definitions = config
     ii = comictaggerlib.issueidentifier.IssueIdentifier(cbz, config, comicvine_api)
     score = ii._get_issue_cover_match_score(
-        "https://comicvine.gamespot.com/a/uploads/scale_large/0/574/585444-109004_20080707014047_large.jpg",
-        ["https://comicvine.gamespot.com/cory-doctorows-futuristic-tales-of-the-here-and-no/4000-140529/"],
-        [("Cover 1", ii.calculate_hash(cbz.get_page(0)))],
+        primary_img_url=data[0],
+        alt_urls=data[1],
+        local_hashes=[("Cover 1", ii.calculate_hash(cbz.get_page(0)))],
+        use_alt_urls=data[2],
     )
-    expected = {
-        "remote_hash": 212201432349720,
-        "score": 0,
-        "url": "https://comicvine.gamespot.com/a/uploads/scale_large/0/574/585444-109004_20080707014047_large.jpg",
-        "local_hash": 212201432349720,
-        "local_hash_name": "Cover 1",
-    }
     assert expected == score