From 28be4d9dd718281ceaf4e30d81fc248f3d493eb9 Mon Sep 17 00:00:00 2001 From: Timmy Welch Date: Sat, 23 Dec 2023 23:47:44 -0800 Subject: [PATCH] Improve errors when loading plugins --- comicapi/comicarchive.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/comicapi/comicarchive.py b/comicapi/comicarchive.py index ed33e5d..4b28773 100644 --- a/comicapi/comicarchive.py +++ b/comicapi/comicarchive.py @@ -49,7 +49,7 @@ def load_archive_plugins() -> None: else: archivers.append(archiver) except Exception: - logger.warning("Failed to load talker: %s", arch.name) + logger.exception("Failed to load archive plugin: %s", arch.name) archivers.extend(builtin) @@ -68,9 +68,17 @@ def load_metadata_plugins(version: str = f"ComicAPI/{version}") -> None: if arch.module.startswith("comicapi"): builtin[style.short_name] = style(version) else: + if style.short_name in styles: + logger.warning( + "Plugin %s is overriding the existing metadata plugin for %s tags", + arch.module, + style.short_name, + ) styles[style.short_name] = style(version) except Exception: logger.exception("Failed to load metadata plugin: %s", arch.name) + for style_name in set(builtin.keys()).intersection(styles): + logger.warning("Builtin metadata for %s tags are being overridden by a plugin", style_name) metadata_styles.clear() metadata_styles.update(builtin) metadata_styles.update(styles)