lordwelch/comictagger
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't save in priority order

Browse Source
This commit is contained in:
Mizaki 2024-05-10 19:23:27 +01:00
parent 7271caccc9
commit 384ac5e33a
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
comictaggerlib/taggerwindow.py
View File

@ -224,7 +224,7 @@ class TaggerWindow(QtWidgets.QMainWindow):
if style not in metadata_styles:
config[0].internal__load_data_style.remove(style)
self.save_data_styles: list[str] = config[0].internal__save_data_style
self.load_data_styles: list[str] = list(reversed(config[0].internal__load_data_style))
self.load_data_styles: list[str] = config[0].internal__load_data_style
self.setAcceptDrops(True)
self.view_tag_actions, self.remove_tag_actions = self.tag_actions()
@ -1224,7 +1224,8 @@ class TaggerWindow(QtWidgets.QMainWindow):
"Change Tag Read Style",
"If you change read tag style(s) now, data in the form will be lost. Are you sure?",
):
self.load_data_styles = list(reversed(load_data_styles))
self.load_data_styles = load_data_styles
self.config[0].internal__load_data_style = load_data_styles
self.update_menus()
if self.comic_archive is not None:
self.load_archive(self.comic_archive)
@ -2097,7 +2098,6 @@ class TaggerWindow(QtWidgets.QMainWindow):
self.config[0].internal__sort_column,
self.config[0].internal__sort_direction,
) = self.fileSelectionList.get_sorting()
self.config[0].internal__load_data_style = self.cbLoadDataStyle.currentData()
ctsettings.save_file(self.config, self.config[0].Runtime_Options__config.user_config_dir / "settings.json")
event.accept()

3
comictaggerlib/ui/customwidgets.py
View File

@ -315,7 +315,8 @@ class CheckableOrderComboBox(QtWidgets.QComboBox):
if event.type() == QEvent.Hide:
self._updateText()
self.justShown = False
self.dropdownClosed.emit(self.currentData())
# Reverse as the display order is in "priority" order for the user whereas overlay requires reversed
self.dropdownClosed.emit(list(reversed(self.currentData())))
# QEvent.MouseButtonPress is inconsistent on activation because double clicks are a thing
if event.type() == QEvent.MouseButtonRelease:
# If self.justShown is true it means that they clicked on the combobox to change the checked items