Fix CV API test. Fix sending last source details in settings for API test and website link.

This commit is contained in:
Mizaki 2022-11-12 23:13:53 +00:00
parent 06ffd9f6be
commit cf12e891b0
2 changed files with 9 additions and 3 deletions

View File

@ -233,8 +233,10 @@ class SettingsWindow(QtWidgets.QDialog):
source_label_logo = QtGui.QPixmap(source.source_details.logo)
source_website_icon_link = QtWidgets.QPushButton()
source_website_icon_link.clicked.connect(lambda _: open_web_link(source.static_options.website))
source_website_icon_link.setToolTip("Click to visit website")
source_website_icon_link.clicked.connect(
lambda state, w=source.static_options.website: open_web_link(w)
)
source_website_icon_link.setToolTip(f"Click to visit website: {source.static_options.website}")
source_website_icon_link.setMaximumSize(250, 100)
if source_label_logo.isNull():
@ -300,7 +302,7 @@ class SettingsWindow(QtWidgets.QDialog):
if option["name"] == "api_key":
btn = QtWidgets.QPushButton("Test Key")
layout_grid.addWidget(btn, row, 2)
btn.clicked.connect(lambda: self.test_api_key(source.source_details.id))
btn.clicked.connect(lambda state, key=source.source_details.id: self.test_api_key(key))
row += 1
if current_widget:

View File

@ -277,6 +277,10 @@ class ComicVineTalker(ComicTalker):
if not url:
url = self.api_base_url
try:
tmp_url = urlsplit(url)
if tmp_url.path and tmp_url.path[-1] != "/":
tmp_url = tmp_url._replace(path=tmp_url.path + "/")
url = tmp_url.geturl()
test_url = urljoin(url, "issue/1/")
cv_response: CVResult = requests.get(