lordwelch/comictagger
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Tidy CV logger errors.

Browse Source
This commit is contained in:
Mizaki 2022-10-28 22:32:33 +01:00
parent bf06b94284
commit dcf853515c
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
comictalker/talkers/comicvine.py
View File

@ -316,12 +316,11 @@ class ComicVineTalker(ComicTalker):
if total_time_waited < self.wait_for_rate_limit_time:
continue
if cv_response["status_code"] != 1:
# TODO Rather than logging and erroring, have error write to log?
logger.debug(
f"Comic Vine query failed with error #{cv_response['status_code']}: [{cv_response['error']}]. \n"
f"Comic Vine query failed with error #{cv_response['status_code']}: [{cv_response['error']}]."
)
raise TalkerNetworkError(
self.source_name_friendly, 0, str(cv_response["status_code"]) + ":" + str(cv_response["error"])
self.source_name_friendly, 0, f"{cv_response['status_code']}: {cv_response['error']}"
)
# it's all good
@ -340,18 +339,18 @@ class ComicVineTalker(ComicTalker):
if resp.status_code == 500:
logger.debug(f"Try #{tries + 1}: ")
time.sleep(1)
logger.debug(str(resp.status_code) + "\n")
logger.debug(str(resp.status_code))
else:
break
except requests.exceptions.Timeout:
logger.debug("Connection to " + self.source_name_friendly + " timed out.\n")
logger.debug(f"Connection to {self.source_name_friendly} timed out.")
raise TalkerNetworkError(self.source_name_friendly, 4)
except requests.exceptions.RequestException as e:
logger.debug(f"{e}\n")
logger.debug(f"Request exception: {e}")
raise TalkerNetworkError(self.source_name_friendly, 0, str(e)) from e
except json.JSONDecodeError as e:
logger.debug(f"{e}\n")
logger.debug(f"JSON decode error: {e}")
raise TalkerDataError(self.source_name_friendly, 2, "ComicVine did not provide json")
raise TalkerNetworkError(self.source_name_friendly, 5)
@ -543,7 +542,7 @@ class ComicVineTalker(ComicTalker):
break
if callback is None:
logger.debug(f"getting another page of results {current_result_count} of {total_result_count}...\n")
logger.debug(f"getting another page of results {current_result_count} of {total_result_count}...")
page += 1
params["page"] = page