Commit Graph

114 Commits

Author SHA1 Message Date
Timmy Welch
2e01672e68 Fix #485
As mentioned in the comment in comictaggerlib/main.py:186
The default value should be None not the empty string.
We also check if the given value is the default or the empty string and
 the setting is unset so the default value is not saved in the settings
 file.
The default_api_url is shown in the GUI Settings Window it is not
 currently show in the cli help.
2023-06-23 17:48:18 -07:00
Timmy Welch
4a7aae4045 Add tests for fix_url 2023-06-23 17:10:40 -07:00
Timmy Welch
31cf687e2f Reduce startup time 2023-06-22 20:11:40 -07:00
Timmy Welch
635cb037f1 Merge branch 'mizaki-fix_add_fields' into develop 2023-06-22 17:51:26 -07:00
Timmy Welch
3a287504ae Fix setting issue and alternate_number on GenericMetadata
IssueString.as_string always returns a string this is a problem for
  GenericMetadata. When the overlay function is used it checks
  specifically for the value None this allows the -m option to unset
  attributes however the issue attribute would get set to the empty
  string when loading ComicRack tags regardless of if there was a value
  stored in the file. Fixes #465 and #480
2023-06-15 20:26:38 -07:00
Mizaki
2afb604ab3 Fix issue_count and add maturity rating 2023-06-08 00:52:24 +01:00
Timmy Welch
a912c7392b Merge branch 'mizaki-additional_comic_fields' into develop 2023-06-03 10:37:44 -07:00
Mizaki
c3892082f5 Change data to metadata 2023-06-02 00:37:58 +01:00
Mizaki
92e2cb42e8 Replace instances of Comic Vine to use the talker's name 2023-06-01 22:05:14 +01:00
Mizaki
a395e5541f Remove invalid comments 2023-05-25 15:00:53 +01:00
Mizaki
d191750231 Remove attempted validation of language and country plus minor changes 2023-05-25 01:32:52 +01:00
Mizaki
e72347656b Add format (1-shot, limited series, etc.) 2023-05-23 00:27:58 +01:00
Mizaki
8e2411a086 Add country functions to utils and try to convert a country name to ISO country name 2023-05-23 00:02:56 +01:00
Mizaki
97e64fa918 Add maturity_rating, language and country to ComicIssue and pass to metadata. 2023-05-18 02:02:21 +01:00
Timmy Welch
661d758315
Merge branch 'mizaki-talker_parse_key' into develop 2023-05-16 17:33:24 -07:00
Mizaki
d65a120eb5 Add issue_count 2023-05-14 00:50:37 +01:00
Mizaki
0b77078a93 Retrieve all fields instead of by (many) names 2023-05-12 23:46:34 +01:00
Mizaki
2598fc546a Use new xlate_int and xlate_float 2023-05-12 22:47:36 +01:00
Mizaki
ddf4407b77 Merge branch 'develop' into additional_comic_fields 2023-05-12 22:41:38 +01:00
Mizaki
6cf259191e Add volume and count_of_volumes to ComicSeries 2023-05-12 21:48:45 +01:00
Timmy Welch
14fa70e608
Separate xlate into separate functions based on return type fixes #454 2023-04-25 15:55:27 -07:00
Mizaki
4218e3558b Add url 2023-03-05 18:58:06 +00:00
Mizaki
271bfac834 Do not fail when talker key is missing 2023-03-03 00:07:49 +00:00
Mizaki
c9638ba0d9 Format manga and rating 2023-03-02 00:10:52 +00:00
Timmy Welch
9bf998ca9e
Remove check_api_url and fix docstrings 2023-02-27 22:29:23 -08:00
Timmy Welch
5b2a06870a
Fix talker settings validation 2023-02-27 22:21:56 -08:00
Mizaki
b4a3e8c2ee Add missing tool tips to labels
Change metadata select label
Use named tuple for talker tabs
Retrun a string and bool for api check
2023-02-24 00:06:48 +00:00
Mizaki
118429f84c Change source term to metadata
Generate API text field in their own function
API tests return string message of result
Add help to text field lables
2023-02-23 00:42:48 +00:00
Mizaki
33ea8da5bc Merge branch 'develop' into talker_settings_generator
# Conflicts:
#	comictaggerlib/settingswindow.py
#	comictalker/talkers/comicvine.py
2023-02-21 00:50:06 +00:00
Timmy Welch
fb83863654
Update plugin settings
Make "runtime" a persistent group, allows normalizing without losing validation
Simplify archiver setting generation
Generate options for setting a url and key for all talkers
Return validated talker settings
Require that the talker id must match the entry point name
Add api_url and api_key as default attributes on talkers
Add default handling of api_url and api_key to register_settings
Update settngs to 0.6.2 to be able to add settings to a group and
  use the display_name attribute
Error if no talkers are loaded
Update talker entry point to comictagger.talker
2023-02-20 16:02:15 -08:00
Timmy Welch
f131c650fb
Merge branch 'mizaki-talker_entry_points' into develop 2023-02-20 14:27:09 -08:00
Mizaki
f439797b03 Use new display_name from settngs. Add source combobox getting and setting and add to sources dict of widgets. 2023-02-20 18:45:39 +00:00
Timmy Welch
c437532622
Merge branch 'mizaki-cache_role_fix' into develop 2023-02-17 10:21:54 -08:00
Timmy Welch
2491999a33
Update copyright statements to ComicTagger Authors 2023-02-16 17:23:13 -08:00
Mizaki
b727b1288d Apply credit datatype to person data from cache 2023-02-15 17:05:14 +00:00
Mizaki
73738010b8 Add additional fields to ComicIssue and add a genre field to ComicSeries to allow for filtering of search results from the cache. 2023-02-15 16:48:07 +00:00
Mizaki
6a6a3320cb Move talker settings menu generator to a separate file 2023-02-14 01:32:56 +00:00
Mizaki
4b3b9d8691 Entry points for talkers 2023-02-10 21:16:35 +00:00
Timmy Welch
4eb9e008ce
Update pre-commit 2023-02-10 00:25:20 -08:00
Timmy Welch
983937cdea
Mark internal functions in ComicVineTalker 2023-02-10 00:23:02 -08:00
Timmy Welch
e5b15abf91
clean up talker 2023-02-10 00:23:00 -08:00
Timmy Welch
ad68726e1d
Use consistent naming for settings
config: always values
setting: always the definition/description not the value
2023-02-04 11:33:21 -08:00
Timmy Welch
d987a811e3
Consolidate plugin code 2023-02-03 20:13:58 -08:00
Mizaki
9aa42c1ca7 Add series match threshold back into search_for_series as it is no longer available via the talkers own settings. 2023-02-03 21:38:17 +00:00
Mizaki
d12325b7f8 Simplify parse_settings. Prefix talker_ to group name. Add back setting CV key via commandline. Other small changes as requested. 2023-02-02 00:53:13 +00:00
Mizaki
94aabcdd40 Merge branch 'develop' into talker_settings
# Conflicts:
#	comictaggerlib/ctoptions/__init__.py
#	comictaggerlib/main.py
#	comictalker/talkers/comicvine.py
2023-02-01 23:38:13 +00:00
Mizaki
839a918330 typed talkers var 2023-02-01 23:22:04 +00:00
Mizaki
c6e3266f60 More verbose attrib string 2023-02-01 15:39:24 +00:00
Mizaki
6a650514fa Rename new settings talker methods. Move parse_settings for talkers to earlier and only pass talkers own settings. 2023-01-30 01:59:23 +00:00
Mizaki
0f10e6e848 Create simple dict of talkers with objects. Moved thresh setting back to talkers (general) as it is called outside of talker. 2023-01-26 00:52:02 +00:00