Fix file encoding inconsistencies, windows defaults to cp1252, which is
not Unicode compatible.
Add logging for all exceptions in the comicapi package
Ensure that all exceptions are logged and shown to the user
Remove no longer used google scripts
Remove convenience files from comicataggerlib and import comicapi directly
Add type-hints to facilitate auto-complete tools
Make PyQt5 code more compatible with PyQt6
Implement automatic tooling
isort and black for code formatting
Line length has been set to 120
flake8 for code standards with exceptions:
E203 - Whitespace before ':' - format compatiblity with black
E501 - Line too long - flake8 line limit cannot be set
E722 - Do not use bare except - fixing bare except statements is a
lot of overhead and there are already
many in the codebase
These changes, along with some manual fixes creates much more readable code.
See examples below:
diff --git a/comicapi/comet.py b/comicapi/comet.py
index d1741c5..52dc195 100644
--- a/comicapi/comet.py
+++ b/comicapi/comet.py
@@ -166,7 +166,2 @@ class CoMet:
- if credit['role'].lower() in set(self.editor_synonyms):
- ET.SubElement(
- root,
- 'editor').text = "{0}".format(
- credit['person'])
@@ -174,2 +169,4 @@ class CoMet:
self.indent(root)
+ if credit["role"].lower() in set(self.editor_synonyms):
+ ET.SubElement(root, "editor").text = str(credit["person"])
diff --git a/comictaggerlib/autotagmatchwindow.py b/comictaggerlib/autotagmatchwindow.py
index 4338176..9219f01 100644
--- a/comictaggerlib/autotagmatchwindow.py
+++ b/comictaggerlib/autotagmatchwindow.py
@@ -63,4 +63,3 @@ class AutoTagMatchWindow(QtWidgets.QDialog):
self.skipButton, QtWidgets.QDialogButtonBox.ActionRole)
- self.buttonBox.button(QtWidgets.QDialogButtonBox.Ok).setText(
- "Accept and Write Tags")
+ self.buttonBox.button(QtWidgets.QDialogButtonBox.StandardButton.Ok).setText("Accept and Write Tags")
diff --git a/comictaggerlib/cli.py b/comictaggerlib/cli.py
index 688907d..dbd0c2e 100644
--- a/comictaggerlib/cli.py
+++ b/comictaggerlib/cli.py
@@ -293,7 +293,3 @@ def process_file_cli(filename, opts, settings, match_results):
if opts.raw:
- print((
- "{0}".format(
- str(
- ca.readRawCIX(),
- errors='ignore'))))
+ print(ca.read_raw_cix())
else:
* Tweaked search string based on new comic vine search behavior
Placated Beaufitul Soup by passing the parser
* First cut at porting to Python 3 and PyQt5
* remove debug print
* tweaked progress dialog handling for issues on ubuntu gui
* Handle bad key more gracefullu
* More integration of unrarlib into settings and rest of app
* Better handling of "personal" unrar lib setting
* PEP 440-compliant version string
* Tuned linux rar help strings
* Got setup working again
* Attempts to build unrar on install
* Some minimal desktop integration on various platforms
* Fix wrong shortfile
* More setup.py enhancements
* Use proper temp file
* Added comment block at top
* Comment out desktop integration attempt for now
* Updated some links and info
* Fixed the html a bit
* Repaired some images that caused libpng to complain
* update readme re: py3qt5 branch changes
* another note
* #108 feat: try to simplify windows build using only pip and python3
* #108 feat: fix python location on appveyor (try 1)
* #108 feat: use venv (try 2)
* #108 feat: use venv (try 3)
* #108 feat: update to latest pyinstaller develop branch
* #108 feat: update to latest pyinstaller develop branch (again)
* #108: add ssl libraries for windows packaging
* #108: refresh env in win build to pick the right mingw
* #108: change order of win build script operations
* #113: fix subprocess usage in pyinstaller package
* bump version
- `autopep8 -aa` for general cleanup;
- Changed order of imports, they should be ordered into 3 groups:
1. standard library imports;
2. 3rd party packages;
3. project imports.
- I commented various imports that were reported as unused by my IDE.
If everything goes fine we can consider to delete them;
- The Apache license disclaimers are now comments since triple-quotes
should be used only for docstrings;
- Fix - `utils.centerWindowOnParent` did not resolve, changed to
`centerWindowOnParent`
