Handle missing-on-init

_locales/en/messages.json

@@ -461,6 +461,10 @@
     "description": "",
     "message": "Show a notification when queueing new downloads"
   },
+  "pref-remove-missing-on-init": {
+    "description": "",
+    "message": "Remove missing downloads after a restart"
+  },
   "pref-show-urls": {
     "description": "",
     "message": "Show URLs instead of Names"

data/prefs.json

@@ -11,6 +11,7 @@
 	"nagging-next": 6,
 	"tooltip": true,
 	"show-urls": false,
+	"remove-missing-on-init": false,
 	"limits": [
 		{
 			"domain": "*",

lib/manager/download.ts

@@ -206,19 +206,22 @@ export class Download extends BaseDownload {
 
   async maybeMissing() {
     if (!this.manId) {
-      return;
+      return null;
     }
     const {manId: id} = this;
     try {
       const dls = await downloads.search({id});
       if (!dls.length) {
         this.setMissing();
+        return this;
       }
     }
     catch (ex) {
       console.error("oops", id, ex.toString(), ex);
       this.setMissing();
+      return this;
     }
+    return null;
   }
 
   adoptSize(state: any) {

lib/manager/man.ts

@@ -10,7 +10,7 @@ import { Bus, Port } from "../bus";
 import { sort } from "../sorting";
 import { Prefs } from "../prefs";
 import { _ } from "../i18n";
-import { CoalescedUpdate, mapFilterInSitu } from "../util";
+import { CoalescedUpdate, mapFilterInSitu, filterInSitu } from "../util";
 import { PromiseSerializer } from "../pserializer";
 import {Download} from "./download";
 import {ManagerPort} from "./port";
@@ -94,8 +94,14 @@ export class Manager extends EventEmitter {
     return this;
   }
 
-  checkMissing() {
-    this.items.forEach(item => item.maybeMissing());
+  async checkMissing() {
+    const serializer = new PromiseSerializer(2);
+    const missing = await Promise.all(this.items.map(
+      item => serializer.scheduleWithContext(item, item.maybeMissing)));
+    if (!(await Prefs.get("remove-missing-on-init"))) {
+      return;
+    }
+    this.remove(filterInSitu(missing, e => !!e));
   }
 
   onChanged(changes: {id: number}) {

lib/pserializer.ts

@@ -91,19 +91,19 @@ export class PromiseSerializer {
     return rv;
   }
 
-  schedule<T>(fn: Function, ...args: any[]): Promise<T> {
+  schedule<T>(fn: Wrapped<T>, ...args: any[]): Promise<T> {
     return this.scheduleWithContext(null, fn, ...args);
   }
 
-  scheduleWithContext<T>(ctx: any, fn: Function, ...args: any[]): Promise<T> {
+  scheduleWithContext<T>(ctx: any, fn: Wrapped<T>, ...args: any[]): Promise<T> {
     return scheduleInternal.call(this, false, ctx, fn, ...args);
   }
 
-  prepend<T>(fn: Function, ...args: any[]): Promise<T> {
+  prepend<T>(fn: Wrapped<T>, ...args: any[]): Promise<T> {
     return this.prependWithContext(null, fn, ...args);
   }
 
-  prependWithContext<T>(ctx: any, fn: Function, ...args: any[]): Promise<T> {
+  prependWithContext<T>(ctx: any, fn: Wrapped<T>, ...args: any[]): Promise<T> {
     return scheduleInternal.call(this, true, ctx, fn, ...args);
   }
 

lib/util.ts

@@ -165,17 +165,23 @@ Object.defineProperty(URL.prototype, "domain", {
  * @param {Object} tp
  * @returns {Array} Filtered array (identity)
  */
-export function filterInSitu<T>(arr: T[], cb: (value: T) => boolean, tp?: any) {
+export function filterInSitu<T>(
+    arr: (T | null | undefined)[], cb: (value: T) => boolean, tp?: any) {
   tp = tp || null;
   let i; let k; let e;
+  const carr = arr as unknown as T[];
   for (i = 0, k = 0, e = arr.length; i < e; i++) {
-    const a = arr[k] = arr[i]; // replace filtered items
-    if (a && cb.call(tp, a, i, arr)) {
+    const a = arr[i]; // replace filtered items
+    if (!a) {
+      continue;
+    }
+    if (cb.call(tp, a, i, arr)) {
+      carr[k] = a;
       k += 1;
     }
   }
-  arr.length = k; // truncate
-  return arr;
+  carr.length = k; // truncate
+  return carr;
 }
 
 /**

windows/prefs.html

@@ -61,6 +61,7 @@
       <label><input type="checkbox" id="pref-open-manager-on-queue"> <span data-i18n="pref-open-manager-on-queue"></span></label>
       <label><input type="checkbox" id="pref-text-links"> <span data-i18n="pref-text-links"></span></label>
       <label><input type="checkbox" id="pref-add-paused"> <span data-i18n="pref-add-paused"></span></label>
+      <label><input type="checkbox" id="pref-remove-missing-on-init"> <span data-i18n="pref-remove-missing-on-init"></span></label>
     </fieldset>
     <fieldset id="pref-conflict-action">
       <legend>When a file exists</legend>

windows/prefs.ts

@@ -553,6 +553,7 @@ addEventListener("DOMContentLoaded", () => {
   new BoolPref("pref-text-links", "text-links");
   new BoolPref("pref-add-paused", "add-paused");
   new BoolPref("pref-show-urls", "show-urls");
+  new BoolPref("pref-remove-missing-on-init", "show-urls");
   new OptionPref("pref-conflict-action", "conflict-action");
 
   $("#reset-confirmations").addEventListener("click", async () => {