From 3834acfa2b05d2651e4df55da5f7e243ff592ffc Mon Sep 17 00:00:00 2001 From: Michael Stapelberg Date: Thu, 7 Jan 2021 22:52:58 +0100 Subject: [PATCH] dhcp4d: ensure MQTT topic names are valid UTF-8 https://twitter.com/zekjur/status/1347295676909158400 --- cmd/dhcp4d/dhcp4d.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cmd/dhcp4d/dhcp4d.go b/cmd/dhcp4d/dhcp4d.go index 5a9b9e1..dbecc4c 100644 --- a/cmd/dhcp4d/dhcp4d.go +++ b/cmd/dhcp4d/dhcp4d.go @@ -416,7 +416,9 @@ func newSrv(permDir string) (*srv, error) { if err != nil { log.Fatal(err) } - identifier := latest.Hostname + // MQTT requires valid UTF-8 and some brokers don’t cope well with + // invalid UTF-8: https://github.com/fhmq/hmq/issues/104 + identifier := strings.ToValidUTF8(latest.Hostname, "") if identifier == "" { identifier = latest.HardwareAddr }