lordwelch/router7
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

defense in depth: verify hex.DecodeString length

Browse Source 
related to #49
This commit is contained in:
Michael Stapelberg 2020-05-27 09:50:04 +02:00
parent ead58ad72c
commit 4a5f55a5de
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/dhcp4d/dhcp4d.go
View File

@ -255,6 +255,10 @@ func (h *Handler) leasePeriodForDevice(hwAddr string) time.Duration {
if err != nil { if err != nil {
return h.LeasePeriod return h.LeasePeriod
} }
if len(hwAddrPrefix) != 6 {
// Invalid MAC address
return h.LeasePeriod
}
hwAddrPrefix = hwAddrPrefix[:3] hwAddrPrefix = hwAddrPrefix[:3]
i := sort.Search(len(nintendoMacPrefixes), func(i int) bool { i := sort.Search(len(nintendoMacPrefixes), func(i int) bool {
return bytes.Compare(nintendoMacPrefixes[i][:], hwAddrPrefix) >= 0 return bytes.Compare(nintendoMacPrefixes[i][:], hwAddrPrefix) >= 0