From 957e4de03a310854d6fee9e2b0186caff6d90eb6 Mon Sep 17 00:00:00 2001 From: Michael Stapelberg Date: Mon, 18 Jun 2018 19:29:58 +0200 Subject: [PATCH] no-op: only one branch results in DHCPNAK --- internal/dhcp4d/dhcp4d.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/internal/dhcp4d/dhcp4d.go b/internal/dhcp4d/dhcp4d.go index 51f5494..cf8bc4b 100644 --- a/internal/dhcp4d/dhcp4d.go +++ b/internal/dhcp4d/dhcp4d.go @@ -164,10 +164,9 @@ func (h *Handler) ServeDHCP(p dhcp4.Packet, msgType dhcp4.MessageType, options d if server, ok := options[dhcp4.OptionServerIdentifier]; ok && !net.IP(server).Equal(h.serverIP) { return nil // message not for this dhcp server } - nak := dhcp4.ReplyPacket(p, dhcp4.NAK, h.serverIP, nil, 0, nil) leaseNum := h.canLease(reqIP, p.CHAddr().String()) if leaseNum == -1 { - return nak + return dhcp4.ReplyPacket(p, dhcp4.NAK, h.serverIP, nil, 0, nil) } lease := &Lease{