lordwelch/router7
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

diag: drain ping reply channel to avoid goroutine leak

Browse Source
This commit is contained in:
Michael Stapelberg 2020-09-14 22:10:09 +02:00
parent 99c4046ebf
commit a8fce3cbbc
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/diag/ping.go
View File

@ -278,6 +278,11 @@ func (d *ping6) Evaluate() (string, error) {
if localAddr[reply.Address.String()] { if localAddr[reply.Address.String()] {
continue continue
} }
go func() {
for range replies {
// drain channel
}
}()
return formatRTT(reply.Duration) + " from " + reply.Address.String(), nil return formatRTT(reply.Duration) + " from " + reply.Address.String(), nil
} }
return "", fmt.Errorf("no responses to %s within %v", addr, timeout) return "", fmt.Errorf("no responses to %s within %v", addr, timeout)