From bef7168112e98194638ecdb880eb384c27d06435 Mon Sep 17 00:00:00 2001 From: Michael Stapelberg Date: Wed, 21 Nov 2018 08:41:07 +0100 Subject: [PATCH] dhcp4: resolve TODOs in comments --- internal/dhcp4/dhcp4.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/dhcp4/dhcp4.go b/internal/dhcp4/dhcp4.go index b8018cd..7d92d50 100644 --- a/internal/dhcp4/dhcp4.go +++ b/internal/dhcp4/dhcp4.go @@ -68,10 +68,10 @@ func (c *Client) packet(xid uint32, opts []layers.DHCPOption) *layers.DHCPv4 { Operation: layers.DHCPOpRequest, HardwareType: layers.LinkTypeEthernet, HardwareLen: uint8(len(layers.EthernetBroadcast)), - HardwareOpts: 0, // TODO: document + HardwareOpts: 0, // clients set this to zero (used by relay agents) Xid: xid, Secs: 0, // TODO: fill in? - Flags: 0, // TODO: document + Flags: 0, // we can receive IP packets via unicast ClientHWAddr: c.hardwareAddr, ServerName: nil, File: nil, @@ -183,7 +183,7 @@ func (c *Client) dhcpRequest() (*layers.DHCPv4, error) { return nil, err } - // Look for DHCPOFFER packet (TODO: RFC) + // Look for DHCPOFFER packet (described in RFC2131 4.3.1): c.connection.SetDeadline(time.Now().Add(10 * time.Second)) for { offer, err := dhcp4.Read(c.connection)