lordwelch/router7
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dhcp4: resolve TODOs in comments

Browse Source
This commit is contained in:
Michael Stapelberg 2018-11-21 08:41:07 +01:00
parent 5b34daeb4e
commit bef7168112
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/dhcp4/dhcp4.go
View File

@ -68,10 +68,10 @@ func (c *Client) packet(xid uint32, opts []layers.DHCPOption) *layers.DHCPv4 {
Operation: layers.DHCPOpRequest, Operation: layers.DHCPOpRequest,
HardwareType: layers.LinkTypeEthernet, HardwareType: layers.LinkTypeEthernet,
HardwareLen: uint8(len(layers.EthernetBroadcast)), HardwareLen: uint8(len(layers.EthernetBroadcast)),
HardwareOpts: 0, // TODO: document HardwareOpts: 0, // clients set this to zero (used by relay agents)
Xid: xid, Xid: xid,
Secs: 0, // TODO: fill in? Secs: 0, // TODO: fill in?
Flags: 0, // TODO: document Flags: 0, // we can receive IP packets via unicast
ClientHWAddr: c.hardwareAddr, ClientHWAddr: c.hardwareAddr,
ServerName: nil, ServerName: nil,
File: nil, File: nil,
@ -183,7 +183,7 @@ func (c *Client) dhcpRequest() (*layers.DHCPv4, error) {
return nil, err return nil, err
} }
// Look for DHCPOFFER packet (TODO: RFC) // Look for DHCPOFFER packet (described in RFC2131 4.3.1):
c.connection.SetDeadline(time.Now().Add(10 * time.Second)) c.connection.SetDeadline(time.Now().Add(10 * time.Second))
for { for {
offer, err := dhcp4.Read(c.connection) offer, err := dhcp4.Read(c.connection)