From decb0978d75020780d3f24ac51588284f1f586e7 Mon Sep 17 00:00:00 2001 From: Michael Stapelberg Date: Thu, 28 May 2020 17:22:24 +0200 Subject: [PATCH] dyndns: update to newer libdns/cloudflare, remove workaround --- go.mod | 2 +- go.sum | 7 +++++++ internal/dyndns/dyndns.go | 6 ------ 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/go.mod b/go.mod index f740e1a..b98028c 100644 --- a/go.mod +++ b/go.mod @@ -22,7 +22,7 @@ require ( github.com/insomniacslk/dhcp v0.0.0-20200420235442-ed3125c2efe7 github.com/jpillora/backoff v1.0.0 github.com/krolaw/dhcp4 v0.0.0-20190909130307-a50d88189771 - github.com/libdns/cloudflare v0.0.0-20200506154110-16482ae4e806 + github.com/libdns/cloudflare v0.0.0-20200528144945-97886e7873b1 github.com/libdns/libdns v0.0.0-20200501023120-186724ffc821 github.com/mdlayher/ndp v0.0.0-20200509194142-8a50b5ef8b52 github.com/mdlayher/raw v0.0.0-20191009151244-50f2db8cc065 diff --git a/go.sum b/go.sum index f37002f..639aff8 100644 --- a/go.sum +++ b/go.sum @@ -133,6 +133,13 @@ github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI= github.com/krolaw/dhcp4 v0.0.0-20190909130307-a50d88189771 h1:t2c2B9g1ZVhMYduqmANSEGVD3/1WlsrEYNPtVoFlENk= github.com/krolaw/dhcp4 v0.0.0-20190909130307-a50d88189771/go.mod h1:0AqAH3ZogsCrvrtUpvc6EtVKbc3w6xwZhkvGLuqyi3o= github.com/lib/pq v1.2.0/go.mod h1:5WUZQaWbwv1U+lTReE5YruASi9Al49XbQIvNi/34Woo= +github.com/libdns/cloudflare v0.0.0-20200506154110-16482ae4e806 h1:7T3AeC4TMBBc2kliYawArGb9eWBRrb6gwcSG2JvKDDw= +github.com/libdns/cloudflare v0.0.0-20200506154110-16482ae4e806/go.mod h1:A9MqNmkZcd81mY7JsNysmgmj5O9vlRjfDVaNw4j9pjU= +github.com/libdns/cloudflare v0.0.0-20200528144945-97886e7873b1 h1:Jx0AoxHtj2NMwxHByM8VmcqvGMa3lEu28xVDArhSi7E= +github.com/libdns/cloudflare v0.0.0-20200528144945-97886e7873b1/go.mod h1:A9MqNmkZcd81mY7JsNysmgmj5O9vlRjfDVaNw4j9pjU= +github.com/libdns/libdns v0.0.0-20200430163404-ee2c42449104/go.mod h1:yQCXzk1lEZmmCPa857bnk4TsOiqYasqpyOEeSObbb40= +github.com/libdns/libdns v0.0.0-20200501023120-186724ffc821 h1:663opx/RKxiISi1ozf0WbvweQpYBgf34dx8hKSIau3w= +github.com/libdns/libdns v0.0.0-20200501023120-186724ffc821/go.mod h1:yQCXzk1lEZmmCPa857bnk4TsOiqYasqpyOEeSObbb40= github.com/lucasb-eyer/go-colorful v0.0.0-20181028223441-12d3b2882a08/go.mod h1:NXg0ArsFk0Y01623LgUqoqcouGDB+PwCCQlrwrG6xJ4= github.com/mattn/go-colorable v0.0.9/go.mod h1:9vuHe8Xs5qXnSaW/c/ABM9alt+Vo+STaOChaDxuIBZU= github.com/mattn/go-isatty v0.0.4/go.mod h1:M+lRXTBqGeGNdLjl/ufCoiOlB5xdOkqRJdNxMWT7Zi4= diff --git a/internal/dyndns/dyndns.go b/internal/dyndns/dyndns.go index 242d86c..aa20346 100644 --- a/internal/dyndns/dyndns.go +++ b/internal/dyndns/dyndns.go @@ -48,12 +48,6 @@ func Update(ctx context.Context, zone string, record libdns.Record, provider Rec return nil } - // TODO: it appears the cloudflare provider expects a non-empty ID to - // mean that a record should be created rather than updated. This behavior - // means that we clear the ID to force an update by the zone name. - // - // See: https://github.com/libdns/cloudflare/issues/1. - rec.ID = "" rec.Value = record.Value updated = append(updated, rec) break