Sanitize group names

updates:
- [github.com/asottile/add-trailing-comma: v3.0.1 → v3.1.0](https://github.com/asottile/add-trailing-comma/compare/v3.0.1...v3.1.0)
- https://github.com/pre-commit/mirrors-autopep8 → https://github.com/hhatto/autopep8
- [github.com/hhatto/autopep8: v2.0.2 → v2.0.4](https://github.com/hhatto/autopep8/compare/v2.0.2...v2.0.4)
- [github.com/pre-commit/mirrors-mypy: v1.5.0 → v1.5.1](https://github.com/pre-commit/mirrors-mypy/compare/v1.5.0...v1.5.1)

.github/workflows/build.yaml

@@ -33,7 +33,7 @@ jobs:
 
       - name: Build and install wheel
         run: |
-          python -m build
+          tox run -m build
           python -m pip install dist/*.whl
 
       - name: tox

.pre-commit-config.yaml

@@ -10,38 +10,38 @@ repos:
     -   id: name-tests-test
     -   id: requirements-txt-fixer
 -   repo: https://github.com/asottile/setup-cfg-fmt
-    rev: v2.2.0
+    rev: v2.4.0
     hooks:
     -   id: setup-cfg-fmt
--   repo: https://github.com/asottile/reorder_python_imports
+-   repo: https://github.com/asottile/reorder-python-imports
-    rev: v3.9.0
+    rev: v3.10.0
     hooks:
     -   id: reorder-python-imports
         args: [--py38-plus, --add-import, 'from __future__ import annotations']
 -   repo: https://github.com/asottile/add-trailing-comma
-    rev: v2.4.0
+    rev: v3.1.0
     hooks:
     -   id: add-trailing-comma
         args: [--py36-plus]
 -   repo: https://github.com/asottile/dead
-    rev: v1.5.0
+    rev: v1.5.2
     hooks:
     -   id: dead
 -   repo: https://github.com/asottile/pyupgrade
-    rev: v3.3.1
+    rev: v3.10.1
     hooks:
     -   id: pyupgrade
         args: [--py38-plus]
--   repo: https://github.com/pre-commit/mirrors-autopep8
+-   repo: https://github.com/hhatto/autopep8
-    rev: v2.0.2
+    rev: v2.0.4
     hooks:
     -   id: autopep8
 -   repo: https://github.com/PyCQA/flake8
-    rev: 6.0.0
+    rev: 6.1.0
     hooks:
     -   id: flake8
         additional_dependencies: [flake8-encodings, flake8-warnings, flake8-builtins, flake8-length, flake8-print]
 -   repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.2.0
+    rev: v1.5.1
     hooks:
     -   id: mypy

pyproject.toml

@@ -0,0 +1,6 @@
+[build-system]
+requires = ["setuptools>=42", "wheel", "setuptools_scm[toml]>=3.4"]
+build-backend = "setuptools.build_meta"
+
+[tool.setuptools_scm]
+local_scheme = "no-local-version"

settngs/__init__.py

@@ -6,6 +6,7 @@ import logging
 import pathlib
 import re
 import sys
+import typing
 from argparse import Namespace
 from collections import defaultdict
 from collections.abc import Sequence
@@ -13,11 +14,12 @@ from typing import Any
 from typing import Callable
 from typing import Dict
 from typing import Generic
+from typing import Literal
 from typing import NoReturn
-from typing import overload
 from typing import TYPE_CHECKING
 from typing import TypeVar
 from typing import Union
+
 logger = logging.getLogger(__name__)
 
 if sys.version_info < (3, 11):  # pragma: no cover
@@ -27,6 +29,9 @@ else:  # pragma: no cover
 
 
 if sys.version_info < (3, 9):  # pragma: no cover
+    from typing import List
+    from typing import _GenericAlias as types_GenericAlias
+
     def removeprefix(self: str, prefix: str, /) -> str:
         if self.startswith(prefix):
             return self[len(prefix):]
@@ -73,6 +78,8 @@ if sys.version_info < (3, 9):  # pragma: no cover
             if option_string in self.option_strings:
                 setattr(namespace, self.dest, not option_string.startswith('--no-'))
 else:  # pragma: no cover
+    List = list
+    from types import GenericAlias as types_GenericAlias
     from argparse import BooleanOptionalAction
     removeprefix = str.removeprefix
 
@@ -82,10 +89,10 @@ class Setting:
         self,
         # From argparse
         *names: str,
-        action: type[argparse.Action] | None = None,
+        action: type[argparse.Action] | str | None = None,
         nargs: str | int | None = None,
-        const: str | None = None,
+        const: Any | None = None,
-        default: str | None = None,
+        default: Any | None = None,
         type: Callable[..., Any] | None = None,  # noqa: A002
         choices: Sequence[Any] | None = None,
         required: bool | None = None,
@@ -111,7 +118,7 @@ class Setting:
             choices:      Passed directly to argparse
             required:     Passed directly to argparse
             help:         Passed directly to argparse
-            metavar:      Passed directly to argparse, defaults to `dest` uppercased
+            metavar:      Passed directly to argparse, defaults to `dest` upper-cased
             dest:         This is the name used to retrieve the value from a `Config` object as a dictionary
             display_name: This is not used by settngs. This is a human-readable name to be used when generating a GUI.
                           Defaults to `dest`.
@@ -134,10 +141,9 @@ class Setting:
             metavar = dest.upper()
 
         # If we are not a flag, no '--' or '-' in front
-        # we prefix the first name with the group as argparse sets dest to args[0]
+        # we use internal_name as argparse sets dest to args[0]
-        # I believe internal name may be able to be used here
         if not flag:
-            args = tuple((f'{group}_{names[0]}'.lstrip('_'), *names[1:]))
+            args = tuple((self.internal_name, *names[1:]))
 
         self.action = action
         self.nargs = nargs
@@ -180,10 +186,52 @@ class Setting:
             return NotImplemented
         return self.__dict__ == other.__dict__
 
+    def _guess_type(self) -> type | Literal['Any'] | None:
+        if self.type is None and self.action is None:
+            if self.cmdline:
+                if self.nargs in ('+', '*') or isinstance(self.nargs, int) and self.nargs > 1:
+                    return List[str]
+                return str
+            else:
+                if not self.cmdline and self.default is not None:
+                    return type(self.default)
+                return 'Any'
+
+        if isinstance(self.type, type):
+            return self.type
+
+        if self.type is not None:
+            type_hints = typing.get_type_hints(self.type)
+            if 'return' in type_hints and isinstance(type_hints['return'], type):
+                return type_hints['return']
+            if self.default is not None:
+                return type(self.default)
+            return 'Any'
+
+        if self.action in ('store_true', 'store_false', BooleanOptionalAction):
+            return bool
+
+        if self.action in ('store_const',):
+            return type(self.const)
+
+        if self.action in ('count',):
+            return int
+
+        if self.action in ('append', 'extend'):
+            return List[str]
+
+        if self.action in ('append_const',):
+            return list  # list[type(self.const)]
+
+        if self.action in ('help', 'version'):
+            return None
+        return 'Any'
+
     def get_dest(self, prefix: str, names: Sequence[str], dest: str | None) -> tuple[str, str, bool]:
         dest_name = None
         flag = False
 
+        prefix = sanitize_name(prefix)
         for n in names:
             if n.startswith('--'):
                 flag = True
@@ -209,6 +257,11 @@ class Setting:
         return self.argparse_args, self.filter_argparse_kwargs()
 
 
+class TypedNS:
+    def __init__(self) -> None:
+        raise TypeError('TypedNS cannot be instantiated')
+
+
 class Group(NamedTuple):
     persistent: bool
     v: dict[str, Setting]
@@ -217,7 +270,7 @@ class Group(NamedTuple):
 Values = Dict[str, Dict[str, Any]]
 Definitions = Dict[str, Group]
 
-T = TypeVar('T', Values, Namespace)
+T = TypeVar('T', bound=Union[Values, Namespace, TypedNS])
 
 
 class Config(NamedTuple, Generic[T]):
@@ -227,16 +280,49 @@ class Config(NamedTuple, Generic[T]):
 
 if TYPE_CHECKING:
     ArgParser = Union[argparse._MutuallyExclusiveGroup, argparse._ArgumentGroup, argparse.ArgumentParser]
-    ns = Namespace | Config[T] | None
+    ns = Namespace | TypedNS | Config[T] | None
+
+
+def generate_ns(definitions: Definitions) -> str:
+    imports = ['from __future__ import annotations', 'import typing', 'import settngs']
+    ns = 'class settngs_namespace(settngs.TypedNS):\n'
+    types = []
+    for group_name, group in definitions.items():
+        for setting_name, setting in group.v.items():
+            t = setting._guess_type()
+            if t is None:
+                continue
+            type_name = 'Any'
+            if isinstance(t, str):
+                type_name = t
+            elif isinstance(t, types_GenericAlias):
+                type_name = str(t)
+            elif isinstance(t, type):
+                type_name = t.__name__
+                if t.__module__ != 'builtins':
+                    imports.append(f'import {t.__module__}')
+                    type_name = t.__module__ + '.' + type_name
+            if type_name == 'Any':
+                type_name = 'typing.Any'
+
+            types.append(f'    {setting.internal_name}: {type_name}')
+        if types and types[-1] != '':
+            types.append('')
+
+    if not types or all(x == '' for x in types):
+        ns += '    ...\n'
+        types = ['']
+
+    return '\n'.join(imports) + '\n\n' + ns + '\n'.join(types)
 
 
 def sanitize_name(name: str) -> str:
     return re.sub('[' + re.escape(' -_,.!@#$%^&*(){}[]\',."<>;:') + ']+', '_', name).strip('_')
 
 
-def get_option(options: Values | Namespace, setting: Setting) -> tuple[Any, bool]:
+def get_option(options: Values | Namespace | TypedNS, setting: Setting) -> tuple[Any, bool]:
     """
-    Helper function to retrieve the value for a setting and if the value is the default value
+    Helper function to retrieve the value for a setting and if the current value is the default value
 
     Args:
         options: Dictionary or namespace of options
@@ -249,20 +335,20 @@ def get_option(options: Values | Namespace, setting: Setting) -> tuple[Any, bool
     return value, value == setting.default
 
 
-def get_options(options: Config[T], group: str) -> dict[str, Any]:
+def get_options(config: Config[T], group: str) -> dict[str, Any]:
     """
     Helper function to retrieve all of the values for a group. Only to be used on persistent groups.
 
     Args:
-        options: Dictionary or namespace of options
+        config: Dictionary or namespace of options
         group: The name of the group to retrieve
     """
-    if isinstance(options[0], dict):
+    if isinstance(config[0], dict):
-        values = options[0].get(group, {}).copy()
+        values: dict[str, Any] = config[0].get(group, {}).copy()
     else:
-        internal_names = {x.internal_name: x for x in options[1][group].v.values()}
+        internal_names = {x.internal_name: x for x in config[1][group].v.values()}
         values = {}
-        v = vars(options[0])
+        v = vars(config[0])
         for name, value in v.items():
             if name.startswith(f'{group}_'):
                 if name in internal_names:
@@ -277,7 +363,7 @@ def normalize_config(
     config: Config[T],
     file: bool = False,
     cmdline: bool = False,
-    defaults: bool = True,
+    default: bool = True,
     persistent: bool = True,
 ) -> Config[Values]:
     """
@@ -286,14 +372,16 @@ def normalize_config(
     Values are assigned so if the value is a dictionary mutating it will mutate the original.
 
     Args:
-        raw_options: The dict or Namespace to normalize options from
+        config: The Config object to normalize options from
-        definitions: The definition of the options
         file: Include file options
         cmdline: Include cmdline options
-        defaults: Include default values in the returned dict
+        default: Include default values in the returned Config object
         persistent: Include unknown keys in persistent groups
     """
 
+    if not file and not cmdline:
+        raise ValueError('Invalid parameters: you must set either file or cmdline to True')
+
     normalized: Values = {}
     options, definitions = config
     for group_name, group in definitions.items():
@@ -303,12 +391,12 @@ def normalize_config(
         for setting_name, setting in group.v.items():
             if (setting.cmdline and cmdline) or (setting.file and file):
                 # Ensures the option exists with the default if not already set
-                value, default = get_option(options, setting)
+                value, is_default = get_option(options, setting)
-                if not default or (default and defaults):
+                if not is_default or default:
                     # User has set a custom value or has requested the default value
                     group_options[setting_name] = value
                 elif setting_name in group_options:
-                    # defaults have been requested to be removed
+                    # default values have been requested to be removed
                     del group_options[setting_name]
             elif setting_name in group_options:
                 # Setting type (file or cmdline) has not been requested and should be removed for persistent groups
@@ -319,8 +407,12 @@ def normalize_config(
 
 def parse_file(definitions: Definitions, filename: pathlib.Path) -> tuple[Config[Values], bool]:
     """
-    Helper function to read options from a json dictionary from a file
+    Helper function to read options from a json dictionary from a file.
+    This is purely a convenience function.
+    If _anything_ more advanced is desired this should be handled by the application.
+
     Args:
+        definitions: A set of setting definitions. See `Config.definitions` and `Manager.definitions`
         filename: A pathlib.Path object to read a json dictionary from
     """
     options: Values = {}
@@ -331,80 +423,91 @@ def parse_file(definitions: Definitions, filename: pathlib.Path) -> tuple[Config
                 opts = json.load(file)
             if isinstance(opts, dict):
                 options = opts
-        except Exception:
+            else:  # pragma: no cover
+                raise Exception('Loaded file is not a JSON Dictionary')
+        except Exception:  # pragma: no cover
             logger.exception('Failed to load config file: %s', filename)
             success = False
     else:
         logger.info('No config file found')
         success = True
 
-    return (normalize_config(Config(options, definitions), file=True), success)
+    return normalize_config(Config(options, definitions), file=True), success
 
 
 def clean_config(
-    config: Config[T], file: bool = False, cmdline: bool = False,
+    config: Config[T], file: bool = False, cmdline: bool = False, default: bool = True, persistent: bool = True,
 ) -> Values:
     """
-    Normalizes options and then cleans up empty groups
+    Normalizes options and then cleans up empty groups. The returned value is probably JSON serializable.
     Args:
-        options:
+        config: The Config object to normalize options from
-        file:
+        file: Include file options
-        cmdline:
+        cmdline: Include cmdline options
-
+        default: Include default values in the returned Config object
-    Returns:
+        persistent: Include unknown keys in persistent groups
-
     """
 
-    clean_options, definitions = normalize_config(config, file=file, cmdline=cmdline)
+    cleaned, _ = normalize_config(config, file=file, cmdline=cmdline, default=default, persistent=persistent)
-    for group in list(clean_options.keys()):
+    for group in list(cleaned.keys()):
-        if not clean_options[group]:
+        if not cleaned[group]:
-            del clean_options[group]
+            del cleaned[group]
-    return clean_options
+    return cleaned
 
 
 def defaults(definitions: Definitions) -> Config[Values]:
     return normalize_config(Config(Namespace(), definitions), file=True, cmdline=True)
 
 
-def get_namespace(config: Config[T], defaults: bool = True, persistent: bool = True) -> Config[Namespace]:
+def get_namespace(
+    config: Config[T], file: bool = False, cmdline: bool = False, default: bool = True, persistent: bool = True,
+) -> Config[Namespace]:
     """
-    Returns an Namespace object with options in the form "{group_name}_{setting_name}"
+    Returns a Namespace object with options in the form "{group_name}_{setting_name}"
-    `options` should already be normalized.
+    `config` should already be normalized or be a `Config[Namespace]`.
-    Throws an exception if the internal_name is duplicated
 
     Args:
-        options: Normalized options to turn into a Namespace
+        config: The Config object to turn into a namespace
-        defaults: Include default values in the returned dict
+        file: Include file options
+        cmdline: Include cmdline options
+        default: Include default values in the returned Config object
         persistent: Include unknown keys in persistent groups
     """
 
-    if isinstance(config.values, Namespace):
+    if not file and not cmdline:
-        options, definitions = normalize_config(config, True, True, defaults=defaults, persistent=persistent)
+        raise ValueError('Invalid parameters: you must set either file or cmdline to True')
+
+    options: Values
+    definitions: Definitions
+    if isinstance(config.values, dict):
+        options = config.values
+        definitions = config.definitions
     else:
-        options, definitions = config
+        cfg = normalize_config(config, file=file, cmdline=cmdline, default=default, persistent=persistent)
+        options, definitions = cfg
     namespace = Namespace()
     for group_name, group in definitions.items():
+
+        group_options = get_options(config, group_name)
         if group.persistent and persistent:
-            group_options = get_options(config, group_name)
             for name, value in group_options.items():
                 if name in group.v:
-                    internal_name, default = group.v[name].internal_name, group.v[name].default == value
+                    setting_file, setting_cmdline = group.v[name].file, group.v[name].cmdline
+                    value, is_default = get_option(options, group.v[name])
+                    internal_name = group.v[name].internal_name
                 else:
-                    internal_name, default = f'{group_name}_' + sanitize_name(name), None
+                    setting_file = setting_cmdline = True
+                    internal_name, is_default = f'{group_name}_' + sanitize_name(name), None
 
-                if hasattr(namespace, internal_name):
+                if ((setting_cmdline and cmdline) or (setting_file and file)) and (not is_default or default):
-                    raise Exception(f'Duplicate internal name: {internal_name}')
-
-                if not default or default and defaults:
                     setattr(namespace, internal_name, value)
 
-        else:
+        for setting in group.v.values():
-            for setting_name, setting in group.v.items():
+            if (setting.cmdline and cmdline) or (setting.file and file):
-                if hasattr(namespace, setting.internal_name):
+                value, is_default = get_option(options, setting)
-                    raise Exception(f'Duplicate internal name: {setting.internal_name}')
-                value, default = get_option(options, setting)
 
-                if not default or default and defaults:
+                if not is_default or default:
+                    # User has set a custom value or has requested the default value
                     setattr(namespace, setting.internal_name, value)
     return Config(namespace, definitions)
 
@@ -414,16 +517,19 @@ def save_file(
 ) -> bool:
     """
     Helper function to save options from a json dictionary to a file
+    This is purely a convenience function.
+    If _anything_ more advanced is desired this should be handled by the application.
+
     Args:
-        options: The options to save to a json dictionary
+        config: The options to save to a json dictionary
         filename: A pathlib.Path object to save the json dictionary to
     """
     file_options = clean_config(config, file=True)
-    if not filename.exists():
-        filename.parent.mkdir(exist_ok=True, parents=True)
-        filename.touch()
-
     try:
+        if not filename.exists():
+            filename.parent.mkdir(exist_ok=True, parents=True)
+            filename.touch()
+
         json_str = json.dumps(file_options, indent=2)
         filename.write_text(json_str + '\n', encoding='utf-8')
     except Exception:
@@ -438,8 +544,8 @@ def create_argparser(definitions: Definitions, description: str, epilog: str) ->
     argparser = argparse.ArgumentParser(
         description=description, epilog=epilog, formatter_class=argparse.RawTextHelpFormatter,
     )
-    for group_name, group in definitions.items():
+    for group in definitions.values():
-        for setting_name, setting in group.v.items():
+        for setting in group.v.values():
             if setting.cmdline:
                 argparse_args, argparse_kwargs = setting.to_argparse()
                 current_group: ArgParser = argparser
@@ -471,17 +577,21 @@ def parse_cmdline(
     `args` and `namespace` are passed to `argparse.ArgumentParser.parse_args`
 
     Args:
-        args: Passed to argparse.ArgumentParser.parse
+        definitions: A set of setting definitions. See `Config.definitions` and `Manager.definitions`
-        namespace: Passed to argparse.ArgumentParser.parse
+        description: Passed to argparse.ArgumentParser
+        epilog: Passed to argparse.ArgumentParser
+        args: Passed to argparse.ArgumentParser.parse_args
+        config: The Config or Namespace object to use as a Namespace passed to argparse.ArgumentParser.parse_args
     """
-    namespace = None
+    namespace: Namespace | TypedNS | None = None
     if isinstance(config, Config):
         if isinstance(config.values, Namespace):
             namespace = config.values
         else:
-            namespace = get_namespace(config, defaults=False)[0]
+            namespace = get_namespace(config, file=True, cmdline=True, default=False)[0]
     else:
         namespace = config
+
     argparser = create_argparser(definitions, description, epilog)
     ns = argparser.parse_args(args, namespace=namespace)
 
@@ -495,13 +605,25 @@ def parse_config(
     config_path: pathlib.Path,
     args: list[str] | None = None,
 ) -> tuple[Config[Values], bool]:
+    """
+    Convenience function to parse options from a json file and passes the resulting Config object to parse_cmdline.
+    This is purely a convenience function.
+    If _anything_ more advanced is desired this should be handled by the application.
+
+    Args:
+        definitions: A set of setting definitions. See `Config.definitions` and `Manager.definitions`
+        description: Passed to argparse.ArgumentParser
+        epilog: Passed to argparse.ArgumentParser
+        config_path: A `pathlib.Path` object
+        args: Passed to argparse.ArgumentParser.parse_args
+    """
     file_options, success = parse_file(definitions, config_path)
     cmdline_options = parse_cmdline(
-        definitions, description, epilog, args, get_namespace(file_options, defaults=False),
+        definitions, description, epilog, args, file_options,
     )
 
     final_options = normalize_config(cmdline_options, file=True, cmdline=True)
-    return (final_options, success)
+    return final_options, success
 
 
 class Manager:
@@ -521,11 +643,14 @@ class Manager:
         self.exclusive_group = False
         self.current_group_name = ''
 
+    def generate_ns(self) -> str:
+        return generate_ns(self.definitions)
+
     def create_argparser(self) -> None:
         self.argparser = create_argparser(self.definitions, self.description, self.epilog)
 
     def add_setting(self, *args: Any, **kwargs: Any) -> None:
-        """Takes passes all arguments through to `Setting`, `group` and `exclusive` are already set"""
+        """Passes all arguments through to `Setting`, `group` and `exclusive` are already set"""
         setting = Setting(*args, **kwargs, group=self.current_group_name, exclusive=self.exclusive_group)
         self.definitions[self.current_group_name].v[setting.dest] = setting
 
@@ -562,7 +687,7 @@ class Manager:
         self.exclusive_group = exclusive_group
         if self.current_group_name in self.definitions:
             if not self.definitions[self.current_group_name].persistent:
-                raise ValueError('Group already existis and is not persistent')
+                raise ValueError('Group already exists and is not persistent')
         else:
             self.definitions[self.current_group_name] = Group(True, {})
         group(self)
@@ -578,63 +703,151 @@ class Manager:
         return defaults(self.definitions)
 
     def clean_config(
-        self, options: T | Config[T], file: bool = False, cmdline: bool = False,
+        self, config: T | Config[T], file: bool = False, cmdline: bool = False,
     ) -> Values:
-        if isinstance(options, Config):
+        """
-            config = options
+        Normalizes options and then cleans up empty groups. The returned value is probably JSON serializable.
-        else:
+        Args:
-            config = Config(options, self.definitions)
+            config: The Config object to normalize options from
+            file: Include file options
+            cmdline: Include cmdline options
+        """
+
+        if not isinstance(config, Config):
+            config = Config(config, self.definitions)
         return clean_config(config, file=file, cmdline=cmdline)
 
     def normalize_config(
         self,
-        options: T | Config[T],
+        config: T | Config[T],
         file: bool = False,
         cmdline: bool = False,
-        defaults: bool = True,
+        default: bool = True,
+        persistent: bool = True,
     ) -> Config[Values]:
-        if isinstance(options, Config):
+        """
-            config = options
+        Creates an `OptionValues` dictionary with setting definitions taken from `self.definitions`
-        else:
+        and values taken from `raw_options` and `raw_options_2' if defined.
-            config = Config(options, self.definitions)
+        Values are assigned so if the value is a dictionary mutating it will mutate the original.
+
+        Args:
+            config: The Config object to normalize options from
+            file: Include file options
+            cmdline: Include cmdline options
+            default: Include default values in the returned Config object
+            persistent: Include unknown keys in persistent groups
+        """
+
+        if not isinstance(config, Config):
+            config = Config(config, self.definitions)
         return normalize_config(
             config=config,
             file=file,
             cmdline=cmdline,
-            defaults=defaults,
+            default=default,
+            persistent=persistent,
         )
 
-    @overload
+    def get_namespace(
-    def get_namespace(self, options: Values, defaults: bool = True) -> Namespace:
+        self,
-        ...
+        config: Values | Config[Values],
+        file: bool = False,
+        cmdline: bool = False,
+        default: bool = True,
+        persistent: bool = True,
+    ) -> Config[Namespace]:
+        """
+        Returns a Namespace object with options in the form "{group_name}_{setting_name}"
+        `options` should already be normalized or be a `Config[Namespace]`.
+        Throws an exception if the internal_name is duplicated
 
-    @overload
+        Args:
-    def get_namespace(self, options: Config[Values], defaults: bool = True) -> Config[Namespace]:
+            config: The Config object to turn into a namespace
-        ...
+            file: Include file options
+            cmdline: Include cmdline options
+            default: Include default values in the returned Config object
+            persistent: Include unknown keys in persistent groups
+        """
 
-    def get_namespace(self, options: Values | Config[Values], defaults: bool = True) -> Config[Namespace] | Namespace:
+        if isinstance(config, Config):
-        if isinstance(options, Config):
+            self.definitions = config[1]
-            self.definitions = options[1]
-            return get_namespace(options, defaults=defaults)
         else:
-            return get_namespace(Config(options, self.definitions), defaults=defaults)
+            config = Config(config, self.definitions)
+        return get_namespace(config, file=file, cmdline=cmdline, default=default, persistent=persistent)
 
     def parse_file(self, filename: pathlib.Path) -> tuple[Config[Values], bool]:
+        """
+        Helper function to read options from a json dictionary from a file.
+        This is purely a convenience function.
+        If _anything_ more advanced is desired this should be handled by the application.
+
+        Args:
+            filename: A pathlib.Path object to read a JSON dictionary from
+        """
         return parse_file(filename=filename, definitions=self.definitions)
 
-    def save_file(self, options: T | Config[T], filename: pathlib.Path) -> bool:
+    def save_file(self, config: T | Config[T], filename: pathlib.Path) -> bool:
-        if isinstance(options, Config):
+        """
-            return save_file(options, filename=filename)
+        Helper function to save options from a json dictionary to a file.
-        return save_file(Config(options, self.definitions), filename=filename)
+        This is purely a convenience function.
+        If _anything_ more advanced is desired this should be handled by the application.
 
-    def parse_cmdline(self, args: list[str] | None = None, namespace: ns[T] = None) -> Config[Values]:
+        Args:
-        return parse_cmdline(self.definitions, self.description, self.epilog, args, namespace)
+            config: The options to save to a json dictionary
+            filename: A pathlib.Path object to save the json dictionary to
+        """
+        if not isinstance(config, Config):
+            config = Config(config, self.definitions)
+        return save_file(config, filename=filename)
+
+    def parse_cmdline(self, args: list[str] | None = None, config: ns[T] = None) -> Config[Values]:
+        """
+        Creates an `argparse.ArgumentParser` from cmdline settings in `self.definitions`.
+        `args` and `config` are passed to `argparse.ArgumentParser.parse_args`
+
+        Args:
+            args: Passed to argparse.ArgumentParser.parse_args
+            config: The Config or Namespace object to use as a Namespace passed to argparse.ArgumentParser.parse_args
+        """
+        return parse_cmdline(self.definitions, self.description, self.epilog, args, config)
 
     def parse_config(self, config_path: pathlib.Path, args: list[str] | None = None) -> tuple[Config[Values], bool]:
+        """
+        Convenience function to parse options from a json file and passes the resulting Config object to parse_cmdline.
+        This is purely a convenience function.
+        If _anything_ more advanced is desired this should be handled by the application.
+
+        Args:
+            config_path: A `pathlib.Path` object
+            args: Passed to argparse.ArgumentParser.parse_args
+        """
         return parse_config(self.definitions, self.description, self.epilog, config_path, args)
 
 
-def example(manager: Manager) -> None:
+__all__ = [
+    'Setting',
+    'Group',
+    'Values',
+    'Definitions',
+    'Config',
+    'generate_settings',
+    'sanitize_name',
+    'get_option',
+    'get_options',
+    'normalize_config',
+    'parse_file',
+    'clean_config',
+    'defaults',
+    'get_namespace',
+    'save_file',
+    'create_argparser',
+    'parse_cmdline',
+    'parse_config',
+    'Manager',
+]
+
+
+def example_group(manager: Manager) -> None:
     manager.add_setting(
         '--hello',
         default='world',
@@ -652,7 +865,7 @@ def example(manager: Manager) -> None:
     )
 
 
-def persistent(manager: Manager) -> None:
+def persistent_group(manager: Manager) -> None:
     manager.add_setting(
         '--test', '-t',
         default=False,
@@ -664,23 +877,23 @@ def _main(args: list[str] | None = None) -> None:
     settings_path = pathlib.Path('./settings.json')
     manager = Manager(description='This is an example', epilog='goodbye!')
 
-    manager.add_group('example', example)
+    manager.add_group('Example Group', example_group)
-    manager.add_persistent_group('persistent', persistent)
+    manager.add_persistent_group('persistent', persistent_group)
 
     file_config, success = manager.parse_file(settings_path)
-    file_namespace = manager.get_namespace(file_config)
+    file_namespace = manager.get_namespace(file_config, file=True, cmdline=True)
 
-    merged_config = manager.parse_cmdline(args=args, namespace=file_namespace)
+    merged_config = manager.parse_cmdline(args=args, config=file_namespace)
-    merged_namespace = manager.get_namespace(merged_config)
+    merged_namespace = manager.get_namespace(merged_config, file=True, cmdline=True)
 
-    print(f'Hello {merged_config.values["example"]["hello"]}')  # noqa: T201
+    print(f'Hello {merged_config.values["Example Group"]["hello"]}')  # noqa: T201
-    if merged_namespace.values.example_save:
+    if merged_namespace.values.Example_Group_save:
         if manager.save_file(merged_config, settings_path):
             print(f'Successfully saved settings to {settings_path}')  # noqa: T201
         else:
             print(f'Failed saving settings to a {settings_path}')  # noqa: T201
-    if merged_namespace.values.example_verbose:
+    if merged_namespace.values.Example_Group_verbose:
-        print(f'{merged_namespace.values.example_verbose=}')  # noqa: T201
+        print(f'{merged_namespace.values.Example_Group_verbose=}')  # noqa: T201
 
 
 if __name__ == '__main__':

setup.cfg

@@ -1,6 +1,5 @@
 [metadata]
 name = settngs
-version = 0.6.3
 description = A library for managing settings
 long_description = file: README.md
 long_description_content_type = text/markdown
@@ -19,7 +18,7 @@ classifiers =
 [options]
 packages = find:
 install_requires =
-    typing-extensions;python_version < '3.11'
+    typing-extensions>=4.3.0;python_version < '3.11'
 python_requires = >=3.8
 include_package_data = True
 
@@ -79,6 +78,8 @@ max_line_length = 120
 [flake8]
 extend-ignore = E501, A003
 max_line_length = 120
+per-file-ignores =
+    *_test.py: LN001
 
 [coverage:run]
 plugins = covdefaults

testing/settngs.py

@@ -15,52 +15,52 @@ example: list[tuple[list[str], str, str]] = [
     (
         ['--hello', 'lordwelch', '-s'],
         'Hello lordwelch\nSuccessfully saved settings to settings.json\n',
-        '{\n  "example": {\n    "hello": "lordwelch",\n    "verbose": false\n  },\n  "persistent": {\n    "test": false\n  }\n}\n',
+        '{\n  "Example Group": {\n    "hello": "lordwelch",\n    "verbose": false\n  },\n  "persistent": {\n    "test": false\n  }\n}\n',
     ),
     (
         [],
         'Hello lordwelch\n',
-        '{\n  "example": {\n    "hello": "lordwelch",\n    "verbose": false\n  },\n  "persistent": {\n    "test": false\n  }\n}\n',
+        '{\n  "Example Group": {\n    "hello": "lordwelch",\n    "verbose": false\n  },\n  "persistent": {\n    "test": false\n  }\n}\n',
     ),
     (
         ['-v'],
-        'Hello lordwelch\nmerged_namespace.values.example_verbose=True\n',
+        'Hello lordwelch\nmerged_namespace.values.Example_Group_verbose=True\n',
-        '{\n  "example": {\n    "hello": "lordwelch",\n    "verbose": false\n  },\n  "persistent": {\n    "test": false\n  }\n}\n',
+        '{\n  "Example Group": {\n    "hello": "lordwelch",\n    "verbose": false\n  },\n  "persistent": {\n    "test": false\n  }\n}\n',
     ),
     (
         ['-v', '-s'],
-        'Hello lordwelch\nSuccessfully saved settings to settings.json\nmerged_namespace.values.example_verbose=True\n',
+        'Hello lordwelch\nSuccessfully saved settings to settings.json\nmerged_namespace.values.Example_Group_verbose=True\n',
-        '{\n  "example": {\n    "hello": "lordwelch",\n    "verbose": true\n  },\n  "persistent": {\n    "test": false\n  }\n}\n',
+        '{\n  "Example Group": {\n    "hello": "lordwelch",\n    "verbose": true\n  },\n  "persistent": {\n    "test": false\n  }\n}\n',
     ),
     (
         [],
-        'Hello lordwelch\nmerged_namespace.values.example_verbose=True\n',
+        'Hello lordwelch\nmerged_namespace.values.Example_Group_verbose=True\n',
-        '{\n  "example": {\n    "hello": "lordwelch",\n    "verbose": true\n  },\n  "persistent": {\n    "test": false\n  }\n}\n',
+        '{\n  "Example Group": {\n    "hello": "lordwelch",\n    "verbose": true\n  },\n  "persistent": {\n    "test": false\n  }\n}\n',
     ),
     (
         ['manual settings.json'],
-        'Hello lordwelch\nmerged_namespace.values.example_verbose=True\n',
+        'Hello lordwelch\nmerged_namespace.values.Example_Group_verbose=True\n',
-        '{\n  "example": {\n    "hello": "lordwelch",\n    "verbose": true\n  },\n  "persistent": {\n    "test": false,\n    "hello": "world"\n  }\n}\n',
+        '{\n  "Example Group": {\n    "hello": "lordwelch",\n    "verbose": true\n  },\n  "persistent": {\n    "test": false,\n    "hello": "world"\n  }\n}\n',
     ),
     (
         ['--no-verbose', '-t'],
         'Hello lordwelch\n',
-        '{\n  "example": {\n    "hello": "lordwelch",\n    "verbose": true\n  },\n  "persistent": {\n    "test": false,\n    "hello": "world"\n  }\n}\n',
+        '{\n  "Example Group": {\n    "hello": "lordwelch",\n    "verbose": true\n  },\n  "persistent": {\n    "test": false,\n    "hello": "world"\n  }\n}\n',
     ),
     (
         ['--no-verbose', '-s', '-t'],
         'Hello lordwelch\nSuccessfully saved settings to settings.json\n',
-        '{\n  "example": {\n    "hello": "lordwelch",\n    "verbose": false\n  },\n  "persistent": {\n    "test": true,\n    "hello": "world"\n  }\n}\n',
+        '{\n  "Example Group": {\n    "hello": "lordwelch",\n    "verbose": false\n  },\n  "persistent": {\n    "test": true,\n    "hello": "world"\n  }\n}\n',
     ),
     (
         ['--hello', 'world', '--no-verbose', '--no-test', '-s'],
         'Hello world\nSuccessfully saved settings to settings.json\n',
-        '{\n  "example": {\n    "hello": "world",\n    "verbose": false\n  },\n  "persistent": {\n    "test": false,\n    "hello": "world"\n  }\n}\n',
+        '{\n  "Example Group": {\n    "hello": "world",\n    "verbose": false\n  },\n  "persistent": {\n    "test": false,\n    "hello": "world"\n  }\n}\n',
     ),
     (
         [],
         'Hello world\n',
-        '{\n  "example": {\n    "hello": "world",\n    "verbose": false\n  },\n  "persistent": {\n    "test": false,\n    "hello": "world"\n  }\n}\n',
+        '{\n  "Example Group": {\n    "hello": "world",\n    "verbose": false\n  },\n  "persistent": {\n    "test": false,\n    "hello": "world"\n  }\n}\n',
     ),
 ]
 success = [

tests/settngs_test.py

@@ -1,8 +1,12 @@
 from __future__ import annotations
 
 import argparse
+import ast
 import json
+import pathlib
+import sys
 from collections import defaultdict
+from typing import Generator
 
 import pytest
 
@@ -13,8 +17,14 @@ from testing.settngs import failure
 from testing.settngs import success
 
 
+if sys.version_info < (3, 9):  # pragma: no cover
+    from typing import List
+else:  # pragma: no cover
+    List = list
+
+
 @pytest.fixture
-def settngs_manager():
+def settngs_manager() -> Generator[settngs.Manager, None, None]:
     manager = settngs.Manager()
     yield manager
 
@@ -53,94 +63,186 @@ def test_add_setting(settngs_manager):
     assert settngs_manager.add_setting('--test') is None
 
 
-def test_get_defaults(settngs_manager):
+class TestValues:
-    settngs_manager.add_setting('--test', default='hello')
+
-    defaults, _ = settngs_manager.defaults()
+    def test_invalid_normalize(self, settngs_manager):
-    assert defaults['']['test'] == 'hello'
+        with pytest.raises(ValueError) as excinfo:
+            settngs_manager.add_setting('--test', default='hello')
+            defaults, _ = settngs_manager.normalize_config({}, file=False, cmdline=False)
+        assert str(excinfo.value) == 'Invalid parameters: you must set either file or cmdline to True'
+
+    def test_get_defaults(self, settngs_manager):
+        settngs_manager.add_setting('--test', default='hello')
+        defaults, _ = settngs_manager.defaults()
+        assert defaults['']['test'] == 'hello'
+
+    def test_get_defaults_group(self, settngs_manager):
+        settngs_manager.add_group('tst', lambda parser: parser.add_setting('--test', default='hello'))
+        defaults, _ = settngs_manager.defaults()
+        assert defaults['tst']['test'] == 'hello'
+
+    def test_get_defaults_group_space(self, settngs_manager):
+        settngs_manager.add_group('Testing tst', lambda parser: parser.add_setting('--test', default='hello'))
+        defaults, _ = settngs_manager.defaults()
+        assert defaults['Testing tst']['test'] == 'hello'
+
+    def test_cmdline_only(self, settngs_manager):
+        settngs_manager.add_group('tst', lambda parser: parser.add_setting('--test', default='hello', file=False))
+        settngs_manager.add_group('tst2', lambda parser: parser.add_setting('--test2', default='hello', cmdline=False))
+
+        file_normalized, _ = settngs_manager.normalize_config(settngs_manager.defaults(), file=True)
+        cmdline_normalized, _ = settngs_manager.normalize_config(settngs_manager.defaults(), cmdline=True)
+
+        assert 'test' not in file_normalized['tst']  # cmdline option not in normalized config
+        assert 'test2' in file_normalized['tst2']  # file option in normalized config
+
+        assert 'test' in cmdline_normalized['tst']  # cmdline option in normalized config
+        assert 'test2' not in cmdline_normalized['tst2']  # file option not in normalized config
+
+    def test_cmdline_only_persistent_group(self, settngs_manager):
+        settngs_manager.add_persistent_group('tst', lambda parser: parser.add_setting('--test', default='hello', file=False))
+        settngs_manager.add_group('tst2', lambda parser: parser.add_setting('--test2', default='hello', cmdline=False))
+
+        file_normalized, _ = settngs_manager.normalize_config(settngs_manager.defaults(), file=True)
+        cmdline_normalized, _ = settngs_manager.normalize_config(settngs_manager.defaults(), cmdline=True)
+
+        assert 'test' not in file_normalized['tst']
+        assert 'test2' in file_normalized['tst2']
+
+        assert 'test' in cmdline_normalized['tst']
+        assert 'test2' not in cmdline_normalized['tst2']
+
+    def test_normalize_defaults(self, settngs_manager):
+        settngs_manager.add_group('tst', lambda parser: parser.add_setting('--test', default='hello'))
+        settngs_manager.add_group('tst', lambda parser: parser.add_setting('--test2', default='hello'))
+        settngs_manager.add_persistent_group('tst_persistent', lambda parser: parser.add_setting('--test', default='hello'))
+
+        defaults = settngs_manager.defaults()
+        defaults_normalized = settngs_manager.normalize_config(defaults, file=True, default=False)
+        assert defaults_normalized.values['tst'] == {}
+        assert defaults_normalized.values['tst_persistent'] == {}
+
+        non_defaults = settngs_manager.defaults()
+        non_defaults.values['tst']['test'] = 'world'
+        non_defaults.values['tst_persistent']['test'] = 'world'
+        non_defaults_normalized = settngs_manager.normalize_config(non_defaults, file=True, default=False)
+
+        assert non_defaults_normalized.values['tst'] == {'test': 'world'}
+        assert non_defaults_normalized.values['tst_persistent'] == {'test': 'world'}
+
+    def test_normalize(self, settngs_manager):
+        settngs_manager.add_group('tst', lambda parser: parser.add_setting('--test', default='hello'))
+        settngs_manager.add_persistent_group('persistent', lambda parser: parser.add_setting('--world', default='world'))
+
+        defaults = settngs_manager.defaults()
+        defaults.values['test'] = 'fail'  # Not defined in settngs_manager, should be removed
+        defaults.values['persistent']['hello'] = 'success'  # Not defined in settngs_manager, should stay
+
+        normalized, _ = settngs_manager.normalize_config(defaults, file=True)
+
+        assert 'test' not in normalized
+        assert 'tst' in normalized
+        assert 'test' in normalized['tst']
+        assert normalized['tst']['test'] == 'hello'
+        assert normalized['persistent']['hello'] == 'success'
+        assert normalized['persistent']['world'] == 'world'
 
 
-def test_get_defaults_namespace(settngs_manager):
+class TestNamespace:
-    settngs_manager.add_setting('--test', default='hello')
+
-    defaults, _ = settngs_manager.get_namespace(settngs_manager.defaults())
+    def test_invalid_normalize(self, settngs_manager):
-    assert defaults.test == 'hello'
+        with pytest.raises(ValueError) as excinfo:
+            settngs_manager.add_setting('--test', default='hello')
+            defaults, _ = settngs_manager.get_namespace(settngs_manager.defaults(), file=False, cmdline=False)
+        assert str(excinfo.value) == 'Invalid parameters: you must set either file or cmdline to True'
+
+    def test_get_defaults(self, settngs_manager):
+        settngs_manager.add_setting('--test', default='hello')
+        defaults, _ = settngs_manager.get_namespace(settngs_manager.defaults(), file=True, cmdline=True)
+        assert defaults.test == 'hello'
+
+    def test_get_defaults_group(self, settngs_manager):
+        settngs_manager.add_group('tst', lambda parser: parser.add_setting('--test', default='hello'))
+        defaults, _ = settngs_manager.get_namespace(settngs_manager.defaults(), file=True, cmdline=True)
+        assert defaults.tst_test == 'hello'
+
+    def test_get_defaults_group_space(self, settngs_manager):
+        settngs_manager.add_group('Testing tst', lambda parser: parser.add_setting('--test', default='hello'))
+        defaults, _ = settngs_manager.get_namespace(settngs_manager.defaults(), file=True, cmdline=True)
+        assert defaults.Testing_tst_test == 'hello'
+
+    def test_cmdline_only(self, settngs_manager):
+        settngs_manager.add_group('tst', lambda parser: parser.add_setting('--test', default='hello', file=False))
+        settngs_manager.add_group('tst2', lambda parser: parser.add_setting('--test2', default='hello', cmdline=False))
+
+        file_normalized, _ = settngs_manager.get_namespace(settngs_manager.normalize_config(settngs_manager.defaults(), file=True), file=True)
+        cmdline_normalized, _ = settngs_manager.get_namespace(settngs_manager.normalize_config(settngs_manager.defaults(), cmdline=True), cmdline=True)
+
+        assert 'tst_test' not in file_normalized.__dict__
+        assert 'tst2_test2' in file_normalized.__dict__
+
+        assert 'tst_test' in cmdline_normalized.__dict__
+        assert 'tst2_test2' not in cmdline_normalized.__dict__
+
+    def test_cmdline_only_persistent_group(self, settngs_manager):
+        settngs_manager.add_persistent_group('tst', lambda parser: parser.add_setting('--test', default='hello', file=False))
+        settngs_manager.add_group('tst2', lambda parser: parser.add_setting('--test2', default='hello', cmdline=False))
+
+        file_normalized, _ = settngs_manager.get_namespace(settngs_manager.normalize_config(settngs_manager.defaults(), file=True), file=True)
+        cmdline_normalized, _ = settngs_manager.get_namespace(settngs_manager.normalize_config(settngs_manager.defaults(), cmdline=True), cmdline=True)
+
+        assert 'tst_test' not in file_normalized.__dict__
+        assert 'tst2_test2' in file_normalized.__dict__
+
+        assert 'tst_test' in cmdline_normalized.__dict__
+        assert 'tst2_test2' not in cmdline_normalized.__dict__
+
+    def test_normalize_defaults(self, settngs_manager):
+        settngs_manager.add_group('tst', lambda parser: parser.add_setting('--test', default='hello'))
+        settngs_manager.add_group('tst', lambda parser: parser.add_setting('--test2', default='hello'))
+        settngs_manager.add_persistent_group('tst_persistent', lambda parser: parser.add_setting('--test', default='hello'))
+
+        defaults = settngs_manager.defaults()
+        defaults_normalized = settngs_manager.get_namespace(settngs_manager.normalize_config(defaults, file=True, default=False), file=True, default=False)
+        assert defaults_normalized.values.__dict__ == {}
+
+        non_defaults = settngs_manager.get_namespace(settngs_manager.defaults(), file=True, cmdline=True)
+        non_defaults.values.tst_test = 'world'
+        non_defaults.values.tst_persistent_test = 'world'
+        non_defaults_normalized = settngs_manager.get_namespace(settngs_manager.normalize_config(non_defaults, file=True, default=False), file=True, default=False)
+
+        assert non_defaults_normalized.values.tst_test == 'world'
+        assert non_defaults_normalized.values.tst_persistent_test == 'world'
+
+    def test_normalize(self, settngs_manager):
+        settngs_manager.add_group('tst', lambda parser: parser.add_setting('--test', default='hello'))
+        settngs_manager.add_persistent_group('persistent', lambda parser: parser.add_setting('--world', default='world'))
+
+        defaults = settngs_manager.get_namespace(settngs_manager.defaults(), file=True, cmdline=True)
+        defaults.values.test = 'fail'  # Not defined in settngs_manager, should be removed
+        defaults.values.persistent_hello = 'success'  # Not defined in settngs_manager, should stay
+
+        normalized, _ = settngs_manager.get_namespace(settngs_manager.normalize_config(defaults, file=True), file=True)
+
+        assert not hasattr(normalized, 'test')
+        assert hasattr(normalized, 'tst_test')
+        assert normalized.tst_test == 'hello'
+        assert normalized.persistent_hello == 'success'
+        assert normalized.persistent_world == 'world'
 
 
 def test_get_namespace_with_namespace(settngs_manager):
     settngs_manager.add_setting('--test', default='hello')
-    defaults, _ = settngs_manager.get_namespace(argparse.Namespace(test='success'))
+    defaults, _ = settngs_manager.get_namespace(argparse.Namespace(test='success'), file=True)
     assert defaults.test == 'success'
 
 
-def test_get_defaults_group(settngs_manager):
-    settngs_manager.add_group('tst', lambda parser: parser.add_setting('--test', default='hello'))
-    defaults, _ = settngs_manager.defaults()
-    assert defaults['tst']['test'] == 'hello'
-
-
 def test_get_namespace_group(settngs_manager):
     settngs_manager.add_group('tst', lambda parser: parser.add_setting('--test', default='hello'))
-    defaults, _ = settngs_manager.get_namespace(settngs_manager.defaults())
+    defaults, _ = settngs_manager.get_namespace(settngs_manager.defaults(), file=True)
     assert defaults.tst_test == 'hello'
 
 
-def test_cmdline_only(settngs_manager):
-    settngs_manager.add_group('tst', lambda parser: parser.add_setting('--test', default='hello', file=False))
-    settngs_manager.add_group('tst2', lambda parser: parser.add_setting('--test2', default='hello', cmdline=False))
-
-    file_normalized, _ = settngs_manager.normalize_config(settngs_manager.defaults(), file=True)
-    cmdline_normalized, _ = settngs_manager.normalize_config(settngs_manager.defaults(), cmdline=True)
-
-    assert 'test' in cmdline_normalized['tst']
-    assert 'test2' not in cmdline_normalized['tst2']
-
-    assert 'test' not in file_normalized['tst']
-    assert 'test2' in file_normalized['tst2']
-
-
-def test_cmdline_only_persistent_group(settngs_manager):
-    settngs_manager.add_persistent_group('tst', lambda parser: parser.add_setting('--test', default='hello', file=False))
-    settngs_manager.add_group('tst2', lambda parser: parser.add_setting('--test2', default='hello', cmdline=False))
-
-    file_normalized, _ = settngs_manager.normalize_config(settngs_manager.defaults(), file=True)
-    cmdline_normalized, _ = settngs_manager.normalize_config(settngs_manager.defaults(), cmdline=True)
-
-    assert 'test' in cmdline_normalized['tst']
-    assert 'test2' not in cmdline_normalized['tst2']
-
-    assert 'test' not in file_normalized['tst']
-    assert 'test2' in file_normalized['tst2']
-
-
-def test_normalize(settngs_manager):
-    settngs_manager.add_group('tst', lambda parser: parser.add_setting('--test', default='hello'))
-    settngs_manager.add_persistent_group('persistent', lambda parser: parser.add_setting('--world', default='world'))
-
-    defaults = settngs_manager.defaults()
-    defaults.values['test'] = 'fail'  # Not defined in settngs_manager, should be removed
-    defaults.values['persistent']['hello'] = 'success'  # Not defined in settngs_manager, should stay
-
-    defaults_namespace = settngs_manager.get_namespace(settngs_manager.defaults())
-    defaults_namespace.values.test = 'fail'  # Not defined in settngs_manager, should be removed
-    defaults_namespace.values.persistent_hello = 'success'  # Not defined in settngs_manager, should stay
-
-    normalized, _ = settngs_manager.normalize_config(defaults, file=True)
-    normalized_from_namespace = settngs_manager.normalize_config(defaults_namespace, file=True)
-    normalized_namespace, _ = settngs_manager.get_namespace(normalized_from_namespace)
-
-    assert 'test' not in normalized
-    assert 'tst' in normalized
-    assert 'test' in normalized['tst']
-    assert normalized['tst']['test'] == 'hello'
-    assert normalized['persistent']['hello'] == 'success'
-    assert normalized['persistent']['world'] == 'world'
-
-    assert not hasattr(normalized_namespace, 'test')
-    assert hasattr(normalized_namespace, 'tst_test')
-    assert normalized_namespace.tst_test == 'hello'
-    assert normalized_namespace.persistent_hello == 'success'
-    assert normalized_namespace.persistent_world == 'world'
-
-
 def test_clean_config(settngs_manager):
     settngs_manager.add_group('tst', lambda parser: parser.add_setting('--test', default='hello', cmdline=False))
     settngs_manager.add_group('tst2', lambda parser: parser.add_setting('--test2', default='hello', file=False))
@@ -180,7 +282,7 @@ def test_parse_cmdline_with_namespace(settngs_manager, ns):
     settngs_manager.add_group('tst', lambda parser: parser.add_setting('--test2', default='fail', cmdline=True))
 
     normalized, _ = settngs_manager.parse_cmdline(
-        ['--test', 'success'], namespace=ns(settngs_manager.definitions),
+        ['--test', 'success'], config=ns(settngs_manager.definitions),
     )
 
     assert 'test' in normalized['tst']
@@ -331,7 +433,7 @@ def test_adding_to_existing_group(settngs_manager, tmp_path):
     assert default_to_regular(settngs_manager.definitions) == default_to_regular(settngs_manager2.definitions)
 
 
-def test_adding_to_existing_persistent_group(settngs_manager, tmp_path):
+def test_adding_to_existing_persistent_group(settngs_manager: settngs.Manager, tmp_path: pathlib.Path) -> None:
     def default_to_regular(d):
         if isinstance(d, defaultdict):
             d = {k: default_to_regular(v) for k, v in d.items()}
@@ -349,6 +451,120 @@ def test_adding_to_existing_persistent_group(settngs_manager, tmp_path):
     assert default_to_regular(settngs_manager.definitions) == default_to_regular(settngs_manager2.definitions)
 
 
+class test_type(int):
+    ...
+
+
+def _typed_function(something: str) -> test_type:  # pragma: no cover
+    return test_type()
+
+
+def _untyped_function(something):
+    ...
+
+
+class _customAction(argparse.Action):  # pragma: no cover
+
+    def __init__(
+        self,
+        option_strings,
+        dest,
+        const=None,
+        default=None,
+        required=False,
+        help=None,  # noqa: A002
+        metavar=None,
+    ):
+        super().__init__(
+            option_strings=option_strings,
+            dest=dest,
+            nargs=0,
+            const=const,
+            default=default,
+            required=required,
+            help=help,
+        )
+
+    def __call__(self, parser, namespace, values, option_string=None):
+        setattr(namespace, self.dest, 'Something')
+
+
+types = (
+    (settngs.Setting('-t', '--test'), str),
+    (settngs.Setting('-t', '--test', cmdline=False), 'Any'),
+    (settngs.Setting('-t', '--test', default=1, file=True, cmdline=False), int),
+    (settngs.Setting('-t', '--test', action='count'), int),
+    (settngs.Setting('-t', '--test', action='append'), List[str]),
+    (settngs.Setting('-t', '--test', action='extend'), List[str]),
+    (settngs.Setting('-t', '--test', action='store_const', const=1), int),
+    (settngs.Setting('-t', '--test', action='append_const', const=1), list),
+    (settngs.Setting('-t', '--test', action='store_true'), bool),
+    (settngs.Setting('-t', '--test', action='store_false'), bool),
+    (settngs.Setting('-t', '--test', action=settngs.BooleanOptionalAction), bool),
+    (settngs.Setting('-t', '--test', action=_customAction), 'Any'),
+    (settngs.Setting('-t', '--test', action='help'), None),
+    (settngs.Setting('-t', '--test', action='version'), None),
+    (settngs.Setting('-t', '--test', type=int), int),
+    (settngs.Setting('-t', '--test', type=_typed_function), test_type),
+    (settngs.Setting('-t', '--test', type=_untyped_function, default=1), int),
+    (settngs.Setting('-t', '--test', type=_untyped_function), 'Any'),
+)
+
+
+@pytest.mark.parametrize('setting,typ', types)
+def test_guess_type(setting, typ):
+    guessed_type = setting._guess_type()
+    assert guessed_type == typ
+
+
+settings = (
+    (lambda parser: parser.add_setting('-t', '--test'), 'str'),
+    (lambda parser: parser.add_setting('-t', '--test', cmdline=False), 'typing.Any'),
+    (lambda parser: parser.add_setting('-t', '--test', default=1, file=True, cmdline=False), 'int'),
+    (lambda parser: parser.add_setting('-t', '--test', action='count'), 'int'),
+    (lambda parser: parser.add_setting('-t', '--test', action='append'), List[str]),
+    (lambda parser: parser.add_setting('-t', '--test', action='extend'), List[str]),
+    (lambda parser: parser.add_setting('-t', '--test', action='store_const', const=1), 'int'),
+    (lambda parser: parser.add_setting('-t', '--test', action='append_const', const=1), 'list'),
+    (lambda parser: parser.add_setting('-t', '--test', action='store_true'), 'bool'),
+    (lambda parser: parser.add_setting('-t', '--test', action='store_false'), 'bool'),
+    (lambda parser: parser.add_setting('-t', '--test', action=settngs.BooleanOptionalAction), 'bool'),
+    (lambda parser: parser.add_setting('-t', '--test', action=_customAction), 'typing.Any'),
+    (lambda parser: parser.add_setting('-t', '--test', action='help'), None),
+    (lambda parser: parser.add_setting('-t', '--test', action='version'), None),
+    (lambda parser: parser.add_setting('-t', '--test', type=int), 'int'),
+    (lambda parser: parser.add_setting('-t', '--test', type=_typed_function), 'tests.settngs_test.test_type'),
+    (lambda parser: parser.add_setting('-t', '--test', type=_untyped_function, default=1), 'int'),
+    (lambda parser: parser.add_setting('-t', '--test', type=_untyped_function), 'typing.Any'),
+)
+
+
+@pytest.mark.parametrize('set_options,typ', settings)
+def test_generate_ns(settngs_manager, set_options, typ):
+    settngs_manager.add_group('test', set_options)
+
+    src = '''\
+from __future__ import annotations
+import typing
+import settngs
+'''
+    if typ == 'tests.settngs_test.test_type':
+        src += 'import tests.settngs_test\n'
+    src += '''
+class settngs_namespace(settngs.TypedNS):
+'''
+    if typ is None:
+        src += '    ...\n'
+    else:
+        src += f'    {settngs_manager.definitions["test"].v["test"].internal_name}: {typ}\n'
+
+    generated_src = settngs_manager.generate_ns()
+
+    assert generated_src == src
+
+    ast.parse(generated_src)
+
+
 def test_example(capsys, tmp_path, monkeypatch):
     monkeypatch.chdir(tmp_path)
     settings_file = tmp_path / 'settings.json'
@@ -358,7 +574,9 @@ def test_example(capsys, tmp_path, monkeypatch):
     for args, expected_out, expected_file in example:
         if args == ['manual settings.json']:
             settings_file.unlink()
-            settings_file.write_text('{\n  "example": {\n    "hello": "lordwelch",\n    "verbose": true\n  },\n  "persistent": {\n    "test": false,\n    "hello": "world"\n  }\n}\n')
+            settings_file.write_text('{\n  "Example Group": {\n    "hello": "lordwelch",\n    "verbose": true\n  },\n  "persistent": {\n    "test": false,\n    "hello": "world"\n  }\n}\n')
+            i += 1
+            continue
         else:
             settngs._main(args)
             captured = capsys.readouterr()