lordwelch/comictagger
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Parametrise cover match test and add ImageHash data

Browse Source
This commit is contained in:
Mizaki 2025-02-14 00:59:10 +00:00 committed by Timmy Welch
parent d2499f6bae
commit 085b599bc4
2 changed files with 86 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
testing/comicdata.py
View File

@ -288,3 +288,76 @@ metadata_prepared = (
),
),
)
issueidentifier_score = (
(
(
comicapi.genericmetadata.ImageHash(
Hash=0, # Force using the alternate, since the alternate is a url it will be ignored
Kind="ahash",
),
["https://comicvine.gamespot.com/cory-doctorows-futuristic-tales-of-the-here-and-no/4000-140529/"],
True,
),
{
"remote_hash": 0,
"score": 31,
"url": "",
"local_hash": 212201432349720,
"local_hash_name": "Cover 1",
},
),
(
(
comicapi.genericmetadata.ImageHash(
Hash=0,
Kind="ahash",
),
[
comicapi.genericmetadata.ImageHash(
Hash=212201432349720,
Kind="ahash",
),
],
True,
),
{
"remote_hash": 212201432349720,
"score": 0,
"url": "",
"local_hash": 212201432349720,
"local_hash_name": "Cover 1",
},
),
(
(
comicapi.genericmetadata.ImageHash(
Hash=212201432349720,
Kind="ahash",
),
["https://comicvine.gamespot.com/cory-doctorows-futuristic-tales-of-the-here-and-no/4000-140529/"],
False,
),
{
"remote_hash": 212201432349720,
"score": 0,
"url": "",
"local_hash": 212201432349720,
"local_hash_name": "Cover 1",
},
),
(
(
"https://comicvine.gamespot.com/a/uploads/scale_large/0/574/585444-109004_20080707014047_large.jpg",
["https://comicvine.gamespot.com/cory-doctorows-futuristic-tales-of-the-here-and-no/4000-140529/"],
False,
),
{
"remote_hash": 212201432349720,
"score": 0,
"url": "https://comicvine.gamespot.com/a/uploads/scale_large/0/574/585444-109004_20080707014047_large.jpg",
"local_hash": 212201432349720,
"local_hash_name": "Cover 1",
},
),
)

24
tests/issueidentifier_test.py
View File

@ -9,6 +9,7 @@ import comictaggerlib.imagehasher
import comictaggerlib.issueidentifier
import testing.comicdata
import testing.comicvine
from comicapi.genericmetadata import ImageHash
from comictaggerlib.resulttypes import IssueResult
@ -36,21 +37,22 @@ def test_get_search_keys(cbz, config, additional_md, expected, comicvine_api):
assert expected == ii._get_search_keys(additional_md)
def test_get_issue_cover_match_score(cbz, config, comicvine_api):
@pytest.mark.parametrize("data, expected", testing.comicdata.issueidentifier_score)
def test_get_issue_cover_match_score(
cbz,
config,
comicvine_api,
data: tuple[str | ImageHash, list[str | ImageHash], bool],
expected: comictaggerlib.issueidentifier.Score,
):
config, definitions = config
ii = comictaggerlib.issueidentifier.IssueIdentifier(cbz, config, comicvine_api)
score = ii._get_issue_cover_match_score(
"https://comicvine.gamespot.com/a/uploads/scale_large/0/574/585444-109004_20080707014047_large.jpg",
["https://comicvine.gamespot.com/cory-doctorows-futuristic-tales-of-the-here-and-no/4000-140529/"],
[("Cover 1", ii.calculate_hash(cbz.get_page(0)))],
primary_img_url=data[0],
alt_urls=data[1],
local_hashes=[("Cover 1", ii.calculate_hash(cbz.get_page(0)))],
use_alt_urls=data[2],
)
expected = {
"remote_hash": 212201432349720,
"score": 0,
"url": "https://comicvine.gamespot.com/a/uploads/scale_large/0/574/585444-109004_20080707014047_large.jpg",
"local_hash": 212201432349720,
"local_hash_name": "Cover 1",
}
assert expected == score