Remove used issue id from get_issue_cover_match_score and fix test

This commit is contained in:
Mizaki 2023-07-18 01:14:32 +01:00
parent f43f51aa2f
commit 3119d68ea2
2 changed files with 2 additions and 11 deletions

View File

@ -277,7 +277,6 @@ class IssueIdentifier:
def get_issue_cover_match_score(
self,
issue_id: str,
primary_img_url: str,
alt_urls: list[str],
local_cover_hash_list: list[int],
@ -513,7 +512,7 @@ class IssueIdentifier:
alt_urls = issue.alt_image_urls
score_item = self.get_issue_cover_match_score(
issue.id, image_url, alt_urls, hash_list, use_remote_alternates=False
image_url, alt_urls, hash_list, use_remote_alternates=False
)
except Exception:
logger.exception("Scoring series failed")
@ -595,7 +594,6 @@ class IssueIdentifier:
self.log_msg(f"Examining alternate covers for ID: {m['series_id']} {m['series']} ...", newline=False)
try:
score_item = self.get_issue_cover_match_score(
m["issue_id"],
m["image_url"],
m["alt_image_urls"],
hash_list,

View File

@ -5,8 +5,6 @@ import io
import pytest
from PIL import Image
import comicapi.comicarchive
import comicapi.issuestring
import comictaggerlib.issueidentifier
import testing.comicdata
import testing.comicvine
@ -37,13 +35,8 @@ def test_get_issue_cover_match_score(cbz, config, comicvine_api):
config, definitions = config
ii = comictaggerlib.issueidentifier.IssueIdentifier(cbz, config, comicvine_api)
score = ii.get_issue_cover_match_score(
int(
comicapi.issuestring.IssueString(
cbz.read_metadata(comicapi.comicarchive.MetaDataStyle.CIX).issue
).as_float()
),
"https://comicvine.gamespot.com/a/uploads/scale_large/0/574/585444-109004_20080707014047_large.jpg",
"https://comicvine.gamespot.com/cory-doctorows-futuristic-tales-of-the-here-and-no/4000-140529/",
["https://comicvine.gamespot.com/cory-doctorows-futuristic-tales-of-the-here-and-no/4000-140529/"],
[ii.calculate_hash(cbz.get_page(0))],
)
expected = {