Fix generation and saving of talker settings fixes #515 #514

This commit is contained in:
Timmy Welch 2023-09-05 14:43:17 -04:00
parent 61d2a8b833
commit 40bd3d5bb8
2 changed files with 5 additions and 5 deletions

View File

@ -463,7 +463,7 @@ class SettingsWindow(QtWidgets.QDialog):
self.config[0].File_Rename_replacements = self.get_replacements()
# Read settings from talker tabs
comictaggerlib.ui.talkeruigenerator.form_settings_to_config(self.sources, self.config)
self.config = comictaggerlib.ui.talkeruigenerator.form_settings_to_config(self.sources, self.config)
self.update_talkers_config()

View File

@ -251,7 +251,7 @@ def generate_source_option_tabs(
comic_talker_tab_layout.addLayout(talker_layout)
# Add source sub tabs to Comic Sources tab
for t_id, talker in talkers.items():
for t_id, talker in list(talkers.items()):
# Add source to general tab dropdown list
sources.cbx_sources.addItem(talker.name, t_id)
tab = TalkerTab(tab=QtWidgets.QWidget(), widgets={})
@ -260,12 +260,12 @@ def generate_source_option_tabs(
url_option: settngs.Setting | None = None
key_option: settngs.Setting | None = None
for option in config.definitions[group_for_plugin(talker)].v.values():
if not option.file:
continue
elif option.dest == f"{t_id}_key":
if option.dest == f"{t_id}_key":
key_option = option
elif option.dest == f"{t_id}_url":
url_option = option
elif not option.file:
continue
elif option._guess_type() is bool:
current_widget = generate_checkbox(option, layout_grid)
tab.widgets[option.dest] = current_widget