lordwelch/comictagger
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix tests

Browse Source
This commit is contained in:
Timmy Welch 2022-07-12 07:43:33 -07:00
parent d206f5f581
commit 46d3e99d48
5 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
comictaggerlib/comiccacher.py
View File

@ -379,8 +379,8 @@ class ComicCacher:
def add_issue_select_details(
self,
issue_id: int,
source_name: str,
issue_id: int,
image_url: str,
thumb_image_url: str,
cover_date: str,

2
comictaggerlib/comicvinetalker.py
View File

@ -677,7 +677,7 @@ class ComicVineTalker:
self, issue_id: int, image_url: str, thumb_url: str, cover_date: str, page_url: str
) -> None:
cvc = ComicCacher()
cvc.add_issue_select_details(issue_id, self.source_name, image_url, thumb_url, cover_date, page_url)
cvc.add_issue_select_details(self.source_name, issue_id, image_url, thumb_url, cover_date, page_url)
def fetch_alternate_cover_urls(self, issue_id: int, issue_page_url: str) -> list[str]:
url_list = self.fetch_cached_alternate_cover_urls(issue_id)

2
tests/comiccacher_test.py
View File

@ -38,7 +38,7 @@ def test_volume_info(comic_cache, volume_info):
@pytest.mark.parametrize("details", select_details)
def test_issue_select_details(comic_cache, details):
comic_cache.add_issue_select_details(**details)
comic_cache.add_issue_select_details(**details, source_name="test")
det = details.copy()
del det["issue_id"]
assert det == comic_cache.get_issue_select_details(details["issue_id"], "test")

2
tests/comicvinetalker_test.py
View File

@ -16,7 +16,7 @@ def test_fetch_volume_data(comicvine_api, settings, mock_now, comic_cache):
assert volume == comic_cache.get_volume_info(23437, ct.source_name)
def test_fetch_issue_data_by_issue_id(comicvine_api, settings, mock_now):
def test_fetch_issue_data_by_issue_id(comicvine_api, settings, mock_now, mock_version):
ct = comictaggerlib.comicvinetalker.ComicVineTalker()
md = ct.fetch_issue_data_by_issue_id(311811, settings)
assert md == testing.comicvine.cv_md

11
tests/conftest.py
View File

@ -56,6 +56,17 @@ def mock_now(monkeypatch):
monkeypatch.setattr(comictaggerlib.comicvinetalker, "datetime", mydatetime)
@pytest.fixture
def mock_version(monkeypatch):
version = "1.4.4a9.dev20"
version_tuple = (1, 4, 4, "dev20")
monkeypatch.setattr(comictaggerlib.ctversion, "version", version)
monkeypatch.setattr(comictaggerlib.ctversion, "__version__", version)
monkeypatch.setattr(comictaggerlib.ctversion, "version_tuple", version_tuple)
monkeypatch.setattr(comictaggerlib.ctversion, "__version_tuple__", version_tuple)
@pytest.fixture
def md():
yield dataclasses.replace(comicapi.genericmetadata.md_test)