e10f7dd7a7
Remove no longer used google scripts
Remove convenience files from comicataggerlib and import comicapi directly
Add type-hints to facilitate auto-complete tools
Make PyQt5 code more compatible with PyQt6
Implement automatic tooling
isort and black for code formatting
Line length has been set to 120
flake8 for code standards with exceptions:
E203 - Whitespace before ':' - format compatiblity with black
E501 - Line too long - flake8 line limit cannot be set
E722 - Do not use bare except - fixing bare except statements is a
lot of overhead and there are already
many in the codebase
These changes, along with some manual fixes creates much more readable code.
See examples below:
diff --git a/comicapi/comet.py b/comicapi/comet.py
index d1741c5..52dc195 100644
--- a/comicapi/comet.py
+++ b/comicapi/comet.py
@@ -166,7 +166,2 @@ class CoMet:
- if credit['role'].lower() in set(self.editor_synonyms):
- ET.SubElement(
- root,
- 'editor').text = "{0}".format(
- credit['person'])
@@ -174,2 +169,4 @@ class CoMet:
self.indent(root)
+ if credit["role"].lower() in set(self.editor_synonyms):
+ ET.SubElement(root, "editor").text = str(credit["person"])
diff --git a/comictaggerlib/autotagmatchwindow.py b/comictaggerlib/autotagmatchwindow.py
index 4338176..9219f01 100644
--- a/comictaggerlib/autotagmatchwindow.py
+++ b/comictaggerlib/autotagmatchwindow.py
@@ -63,4 +63,3 @@ class AutoTagMatchWindow(QtWidgets.QDialog):
self.skipButton, QtWidgets.QDialogButtonBox.ActionRole)
- self.buttonBox.button(QtWidgets.QDialogButtonBox.Ok).setText(
- "Accept and Write Tags")
+ self.buttonBox.button(QtWidgets.QDialogButtonBox.StandardButton.Ok).setText("Accept and Write Tags")
diff --git a/comictaggerlib/cli.py b/comictaggerlib/cli.py
index 688907d..dbd0c2e 100644
--- a/comictaggerlib/cli.py
+++ b/comictaggerlib/cli.py
@@ -293,7 +293,3 @@ def process_file_cli(filename, opts, settings, match_results):
if opts.raw:
- print((
- "{0}".format(
- str(
- ca.readRawCIX(),
- errors='ignore'))))
+ print(ca.read_raw_cix())
else:
103 lines
2.8 KiB
Plaintext
103 lines
2.8 KiB
Plaintext
TOP!:
|
|
Does utils.get_actual_preferred_encoding() work on Mac python source version??
|
|
(And does it matter?)
|
|
|
|
-----------------------------------------------------
|
|
Features
|
|
-----------------------------------------------------
|
|
Rename dialog:
|
|
check-box for rows?
|
|
manual edit the preview?
|
|
|
|
Maybe replace configparser -- seems to be causing all sorts of problems
|
|
|
|
Feature Requests:
|
|
Move CBR to other folder after conversion to ZIP
|
|
Pre-process series name before identification
|
|
(using a list of regex transforms)
|
|
(GC #24) Multiple options for -t i.e. "-t cr,cbl"
|
|
(GC #18 ) Option for handling colon in rename
|
|
(GC #31 ) Specify CV Series ID for auto-tag
|
|
Re-org - move to new folder based on template
|
|
|
|
Denied Requests (for now):
|
|
Auto-rename on auto-tag
|
|
Re-zip (to remove compression)
|
|
|
|
|
|
Selective fields on CLI print (use -m option. Maybe internally remove all but specified fields in MD object before print )
|
|
|
|
Docs:
|
|
Auto-Tagging Tips:
|
|
Multiple Passes with different options
|
|
|
|
-----------------------------------------------------
|
|
Bugs
|
|
-----------------------------------------------------
|
|
|
|
Zip flakes out when filename differs from index (or whatever) i.e "\" vs "/". Python issue
|
|
|
|
|
|
|
|
-----------------------------------------------------
|
|
Big Future Features
|
|
-----------------------------------------------------
|
|
Support for ACBF metadata in CBZ
|
|
|
|
GCD scraper or DB reader
|
|
|
|
(GC #29) Batch Edit
|
|
Form Mode: Single vs Batch
|
|
|
|
-----------------------------------------------------
|
|
Small(er) Future Feature
|
|
-----------------------------------------------------
|
|
Parse out the rest of the scan info from filename
|
|
|
|
Style sheets for windows/mac/linux
|
|
|
|
CLI
|
|
explicit metadata settings option format
|
|
-- figure out how to add CBI "tags"
|
|
-- delete CBI "tags"
|
|
-- set primary credit flags
|
|
-- set frontcover and others?
|
|
|
|
Archive function to detect tag blocks out of sync
|
|
|
|
Settings
|
|
Add setting to dis-allow writing CBI to RAR
|
|
|
|
Google App engine to store hashes
|
|
Content Hashes, Image hashes, who knows?
|
|
|
|
Filename parsing:
|
|
Rework how series name is separated from issue
|
|
|
|
Internal GenericMetadata - Make Characters, Genre into lists?
|
|
|
|
-----------------------------------------------------
|
|
Config Mgmt check list
|
|
-----------------------------------------------------
|
|
|
|
Release Process
|
|
Optionally, make screen shots, upload to wiki
|
|
Update release notes and wiki
|
|
Update ctversion.py
|
|
Build packages
|
|
Make exe on Windows
|
|
Make dmg on Mac
|
|
Make zip on Mac or Linux
|
|
Tag the repository
|
|
Manually upload release packages to Google Drive
|
|
Update the Downloads wiki page with direct links
|
|
"make upload" to the pypi site
|
|
Announce on Forum and Main Page and Twitter and Facebook
|
|
MacUpdate
|
|
Update appspot value
|
|
|
|
----------------------------------------------
|
|
|
|
|
|
rename 's/([A-Za-z]+)(\d+)(.cb[rz])/$1 $2$3/' *.cb?
|