Version 4.0.2

As a clue that this is supported. See #2

TODO.md

@@ -3,14 +3,6 @@ TODO
 
 aka a lot
 
-P1
-===
-
-Musts.
-
-* packaging
-  * signing
-
 P2
 ===
 

lib/recentlist.ts

@@ -102,8 +102,8 @@ export const MASK = new RecentList("mask", [
   "*name*.*ext*",
   "*num*_*name*.*ext*",
   "*url*-*name*.*ext*",
-  "*name* (*text*).*ext*",
-  "*name* (*hh*-*mm*).*ext*"
+  "downthemall/*y*-*m*/*name*.*ext*",
+  "*name* (*text*).*ext*"
 ]);
 MASK.init().catch(console.error);
 

manifest.json

@@ -1,7 +1,7 @@
 {
   "manifest_version": 2,
   "name": "DownThemAll!",
-  "version": "4.0.1",
+  "version": "4.0.2",
 
   "description": "__MSG_extensionDescription__",
   "homepage_url": "https://downthemall.org/",

scripts/gather.ts

@@ -92,47 +92,62 @@ class Gatherer {
     this.schemes = new Set(options.schemes);
     this.transferable = options.transferable;
     this.collectLink = this.collectLink.bind(this);
-    this.collectImages = this.collectImages.bind(this);
+    this.collectImage = this.collectImage.bind(this);
     this.collectMedia = this.collectMedia.bind(this);
     Object.freeze(this);
   }
 
   collectLink(a: HTMLAnchorElement) {
-    const item = this.makeItem(a.href, a);
-    if (!item) {
+    try {
+      const item = this.makeItem(a.href, a);
+      if (!item) {
+        return item;
+      }
+      urlToUsable(item, item.url);
+      item.fileName = sanitize(a.getAttribute("download"));
+      item.description = extractDescription(a);
       return item;
     }
-    urlToUsable(item, item.url);
-    item.fileName = sanitize(a.getAttribute("download"));
-    item.description = extractDescription(a);
-    return item;
+    catch (ex) {
+      console.error("oopsed link", ex.toString(), ex);
+    }
+    return null;
   }
 
-  *collectImagesInternal(img: HTMLImageElement) {
-    const src = img.currentSrc || img.src;
-    const item = this.makeItem(src, img);
-    item.fileName = "";
-    item.description = item.title;
-    yield item;
-
-    const {srcset} = img;
-    if (!srcset) {
-      return;
-    }
-    const imgs = srcset.split(",").flatMap(e => {
-      const idx = e.lastIndexOf(" ");
-      return (idx > 0 ? e.slice(0, idx) : e).trim();
-    });
-    for (const i of imgs) {
-      const item = this.makeItem(i, img);
+  *collectImageInternal(img: HTMLImageElement) {
+    try {
+      const src = img.currentSrc || img.src;
+      const item = this.makeItem(src, img);
       if (item) {
+        item.fileName = "";
+        item.description = item.title;
         yield item;
       }
+
+      const {srcset} = img;
+      if (!srcset) {
+        return;
+      }
+      const imgs = srcset.split(",").flatMap(e => {
+        const idx = e.lastIndexOf(" ");
+        return (idx > 0 ? e.slice(0, idx) : e).trim();
+      });
+      for (const i of imgs) {
+        const item = this.makeItem(i, img);
+        if (item) {
+          item.fileName = "";
+          item.description = item.title;
+          yield item;
+        }
+      }
+    }
+    catch (ex) {
+      console.error("oops image", ex.toString(), ex.stack, ex);
     }
   }
 
-  collectImages(img: HTMLImageElement) {
-    return [...this.collectImagesInternal(img)];
+  collectImage(img: HTMLImageElement) {
+    return [...this.collectImageInternal(img)];
   }
 
   collectMediaInternal(title: string | undefined | null, el: HTMLMediaElement) {
@@ -156,13 +171,19 @@ class Gatherer {
   }
 
   collectMedia(el: HTMLMediaElement) {
-    const item = this.collectMediaInternal(el.getAttribute("title"), el);
-    const rv = item ? [item] : [];
-    const title: string | undefined = item && item.title ||
+    try {
+      const item = this.collectMediaInternal(el.getAttribute("title"), el);
+      const rv = item ? [item] : [];
+      const title: string | undefined = item && item.title ||
       el.getAttribute("title");
-    rv.push(...Array.from(el.querySelectorAll("source")).
-      map(this.collectMediaInternal.bind(this, title)));
-    return rv;
+      rv.push(...Array.from(el.querySelectorAll("source")).
+        map(this.collectMediaInternal.bind(this, title)));
+      return rv;
+    }
+    catch (ex) {
+      console.log("oopsed media", ex.toString(), ex);
+    }
+    return [];
   }
 
   *findTexts() {
@@ -207,8 +228,14 @@ class Gatherer {
     if (!this.textLinks) {
       return [];
     }
-    return Array.from(this.findTextLinks()).
-      map(link => this.makeItem(link.href, link));
+    try {
+      return Array.from(this.findTextLinks()).
+        map(link => this.makeItem(link.href, link));
+    }
+    catch (ex) {
+      console.error("oopsed textlinks", ex.toString(), ex);
+    }
+    return [];
   }
 
   makeItem(surl: string, el: HTMLElement, title?: string | null): any {
@@ -276,7 +303,7 @@ function gather(msg: any, sender: any, callback: Function) {
         gatherer.collectTextLinks()),
       media: gatherer.makeUniqueItems(
         Array.from(document.querySelectorAll("img")).
-          flatMap(gatherer.collectImages),
+          flatMap(gatherer.collectImage),
         Array.from(document.querySelectorAll("video")).
           flatMap(gatherer.collectMedia),
         Array.from(document.querySelectorAll("audio")).